From: Jens Axboe <axboe@kernel.dk>
To: Taisuke Yamada <tai@rakugaki.org>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH 1/2] Added replay_rebase option to run multi-threaded log replay on different disk sectors.
Date: Thu, 15 Sep 2011 13:10:20 +0200 [thread overview]
Message-ID: <4E71DD1C.1060708@kernel.dk> (raw)
In-Reply-To: <CAM8qCPLxw2zSS1tQudnurDSMZcugrc_Cf=9MLfK2D_RphmMn9A@mail.gmail.com>
On 2011-09-15 08:23, Taisuke Yamada wrote:
>>> [snip], I added "replay_rebase" option to shift offset of IO request for
>>> each thread.
>>
>> Thanks, I can see this being handy. I can apply this, but I would much
>> prefer if you resend it with the proper updates to HOWTO and fio.1
>> adding the new option. Otherwise nobody is going to learn about it.
>
> Just in case you have missed (I had to break In-Reply-To chain as git
> format-patch did not respect it). I'm re-posting updated patch with docs.
> Please apply #1 and #2 if it seems acceptable.
>
> I believe #2 patch is also worth adding to fio, but not sure if I should make
> it optional feature (/w doc) or not. By wraparounding offset address, it'll
> probably make benchmark result look better than actual for rotational disk
> drives. OTOH, it's better than failing to run just because trace-generating
> device was larger than replaying device.
I worry about the 2nd patch, it's a bit of a hack. You could make it an
option and turn it on unconditionally for replay_rebase, or at least
make it conditional on that.
--
Jens Axboe
next prev parent reply other threads:[~2011-09-15 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 5:12 [PATCH 1/2] Added replay_rebase option to run multi-threaded log replay on different disk sectors Taisuke Yamada
2011-09-09 8:37 ` Jens Axboe
2011-09-15 6:23 ` Taisuke Yamada
2011-09-15 11:10 ` Jens Axboe [this message]
2011-09-15 11:52 ` Taisuke Yamada
2011-09-15 11:14 ` Jens Axboe
2011-09-15 11:40 ` Taisuke Yamada
2011-09-15 11:42 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2011-09-12 5:30 Taisuke Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71DD1C.1060708@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=tai@rakugaki.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.