From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tabi Timur-B04825 Subject: Re: [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver Date: Thu, 15 Sep 2011 11:28:03 +0000 Message-ID: <4E71E142.1090301@freescale.com> References: <1315936777-27994-1-git-send-email-timur@freescale.com> <1316003710.3229.14.camel@odin> <4E7121DC.908@freescale.com> <20110915102643.GE7988@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from VA3EHSOBE002.bigfish.com (va3ehsobe002.messaging.microsoft.com [216.32.180.12]) by alsa0.perex.cz (Postfix) with ESMTP id 7026F2450A for ; Thu, 15 Sep 2011 13:30:35 +0200 (CEST) In-Reply-To: <20110915102643.GE7988@opensource.wolfsonmicro.com> Content-Language: en-US Content-ID: <0AB87A227E196C45946FFB9CA598E88F@freescale.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "alsa-devel@alsa-project.org" , Tabi Timur-B04825 , Liam Girdwood List-Id: alsa-devel@alsa-project.org Mark Brown wrote: >> > dev_err(codec->dev, "Unsupported sample size: %i\n", i); > There's no meaningful cost in calling the function twice Perhaps. > and it'd be > much more legible to do so. Well, I just don't agree with that. It's pretty obvious what 'i' is. -- Timur Tabi Linux kernel developer at Freescale