From: Felix Fietkau <nbd@openwrt.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v2] mac80211: stop tx before doing hw config and rate update
Date: Fri, 16 Sep 2011 09:56:55 +0200 [thread overview]
Message-ID: <4E730147.1090408@openwrt.org> (raw)
In-Reply-To: <1314951719-9816-1-git-send-email-rmanohar@qca.qualcomm.com>
On 2011-09-02 10:21 AM, Rajkumar Manoharan wrote:
> The assumption is that during the hw config, transmission was
> already stopped by mac80211. Sometimes the AP can be switching
> b/w the ht modes due to intolerant or etc where STA is in
> the middle of transmission. In such scenario, buffer overflow
> was observed at driver side. And also before updating the rate
> control, the frames are continued to xmited with older rates.
> This patch ensures that the frames are always xmitted with
> updated rates and avoid buffer overflow.
>
> Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
John, please revert this one, it's completely messed up. It stops
queues, and calls drv_flush whenever it receives a beacon with 802.11n
information, even if 802.11n is already enabled and the mode is the
correct one.
Additionally, it even wakes the queues again before the settings have
been applied, so it's 100% useless.
- Felix
next prev parent reply other threads:[~2011-09-16 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 8:21 [PATCH v2] mac80211: stop tx before doing hw config and rate update Rajkumar Manoharan
2011-09-02 8:23 ` Johannes Berg
2011-09-16 7:56 ` Felix Fietkau [this message]
2011-09-16 9:27 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E730147.1090408@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.