From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/4] kbuild: introduce KBUILD_CONFIG; unexpose KCONFIG_CONFIG
Date: Fri, 16 Sep 2011 14:31:07 +0200 [thread overview]
Message-ID: <4E73418B.4050802@suse.cz> (raw)
In-Reply-To: <1313472854-14426-2-git-send-email-lacombar@gmail.com>
On 16.8.2011 07:34, Arnaud Lacombe wrote:
> Refine the Kbuild interface to expose it's own variable to architecture
> Makefile's and prepare Kconfig environment prior to any %config invocation.
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> Makefile | 8 ++++++--
> arch/arm/boot/compressed/Makefile | 2 +-
> arch/unicore32/boot/compressed/Makefile | 2 +-
> scripts/kconfig/Makefile | 3 +++
> 4 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b4ca4e1..26798a4 100644
> --- a/Makefile
> +++ b/Makefile
[...]
> +# Prepare Kconfig environment
> +KCONFIG_CONFIG = $(KBUILD_CONFIG)
> +export KCONFIG_CONFIG
IMO we should preserve the semantics of KCONFIG_CONFIG as much as
possible. make KCONFIG_CONFIG=blah works, but setting it in the
environment does not, because the '=' assignment take precendence.
Michal
next prev parent reply other threads:[~2011-09-16 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 5:34 [PATCH 0/4] Kbuild/Kconfig Arnaud Lacombe
2011-08-16 5:34 ` [PATCH 1/4] kbuild: introduce KBUILD_CONFIG; unexpose KCONFIG_CONFIG Arnaud Lacombe
2011-09-16 12:31 ` Michal Marek [this message]
2011-09-16 12:33 ` Michal Marek
2011-08-16 5:34 ` [PATCH 2/4] kbuild: reduce kbuild invasivity within kconfig Arnaud Lacombe
2011-08-16 5:34 ` [PATCH 3/4] kbuild: do not hardcode .config Arnaud Lacombe
2011-08-16 5:34 ` [PATCH 4/4] kconfig: " Arnaud Lacombe
2011-08-22 15:49 ` [PATCH 0/4] Kbuild/Kconfig Arnaud Lacombe
2011-08-30 0:29 ` Arnaud Lacombe
2011-09-06 15:05 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E73418B.4050802@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.