From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R4YEY-0002HN-8D
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:13:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R4YEW-0002Jt-RM
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:13:34 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:52966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R4YEW-0002Jn-Lw
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 09:13:32 -0400
Received: by ywm39 with SMTP id 39so3526060ywm.4
	for <qemu-devel@nongnu.org>; Fri, 16 Sep 2011 06:13:32 -0700 (PDT)
Message-ID: <4E734B79.3000300@codemonkey.ws>
Date: Fri, 16 Sep 2011 08:13:29 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <CAEXQZf2g-gTdoCY6cJizcFCOP+LhCZ4sVZeXamccF_wu3jEj-g@mail.gmail.com>
In-Reply-To: <CAEXQZf2g-gTdoCY6cJizcFCOP+LhCZ4sVZeXamccF_wu3jEj-g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Boris Dolgov <boris@dolgov.name>
Cc: qemu-devel@nongnu.org

On 09/14/2011 09:16 AM, Boris Dolgov wrote:
> Hello!
>
> Qemu 0.15.0 doesn't build with vnc support disabled. The following
> patch fixes the problem.
>
> Signed-off-by: Boris Dolgov<boris@dolgov.name>

Please submit patches against the latest git tree (and use git diff to generate 
the diff).

Regards,

Anthony Liguori

>
> --
>
> --- monitor.c.orig	2011-09-14 18:11:12.235199764 +0400
> +++ monitor.c	2011-09-14 18:12:19.187709823 +0400
> @@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
>           }
>   	qerror_report(QERR_ADD_CLIENT_FAILED);
>   	return -1;
> +#ifdef CONFIG_VNC
>       } else if (strcmp(protocol, "vnc") == 0) {
>   	int fd = monitor_get_fd(mon, fdname);
>   	vnc_display_add_client(NULL, fd, skipauth);
>   	return 0;
> +#endif
>       } else if ((s = qemu_chr_find(protocol)) != NULL) {
>   	int fd = monitor_get_fd(mon, fdname);
>   	if (qemu_chr_add_client(s, fd)<  0) {
>
>