All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias
Date: Fri, 16 Sep 2011 09:09:34 -0500	[thread overview]
Message-ID: <4E73589E.7010308@us.ibm.com> (raw)
In-Reply-To: <4E71C4E0.9000007@siemens.com>

On 09/15/2011 04:26 AM, Jan Kiszka wrote:
> This does not yet unbreak PPC (which has its own problems) but
> potentially other non-x86 systems where isa_mem_base is != 0.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/vga.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/vga.c b/hw/vga.c
> index 125fb29..0a0c5a6 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -181,6 +181,7 @@ static void vga_update_memory_access(VGACommonState *s)
>               size = 0x8000;
>               break;
>           }
> +        base += isa_mem_base;
>           region = g_malloc(sizeof(*region));
>           memory_region_init_alias(region, "vga.chain4",&s->vram, offset, size);
>           memory_region_add_subregion_overlap(s->legacy_address_space, base,

      reply	other threads:[~2011-09-16 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  9:26 [Qemu-devel] [PATCH] vga: Respect isa_mem_base when registering chain4 alias Jan Kiszka
2011-09-16 14:09 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E73589E.7010308@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.