From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ZS1-0007ws-Tg for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:31:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4ZRz-0006S3-Cg for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:31:33 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ZRz-0006RH-83 for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:31:31 -0400 Message-ID: <4E735DB6.1030209@mail.berlios.de> Date: Fri, 16 Sep 2011 16:31:18 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1315760411-26359-1-git-send-email-weil@mail.berlios.de> <4E734A0D.3010309@codemonkey.ws> In-Reply-To: <4E734A0D.3010309@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add astyle option file for code formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 16.09.2011 15:07, schrieb Anthony Liguori: > On 09/11/2011 12:00 PM, Stefan Weil wrote: >> For new C code (and maybe also for existing code), a code formatter >> like Artistic Style is helpful because it can fix tabs, indentation >> and other style issues. >> >> This option file tries to set astyle options which match QEMU's >> coding conventions. >> >> The quality of astyle's code formatting depends on the astyle version >> (I got best results with newer versions) and on the code which is going >> to be formatted. >> >> For some code, formatting of brackets and operators does not work well. >> Fixing indentation and tabs always worked well for me. >> >> Signed-off-by: Stefan Weil >> --- >> scripts/astylerc | 16 ++++++++++++++++ >> 1 files changed, 16 insertions(+), 0 deletions(-) >> create mode 100644 scripts/astylerc >> > Please put a copyright in this file. > > FWIW, this is what I use with emacs: > > (c-add-style "qemu" > '("stroustrup" > (indent-tabs-mode . nil) > (c-basic-offset . 4) > (tab-width . 8) > ) > nil) ; t = set this style, nil = don't > > Regards, > > Anthony Liguori Are you sure that you want a copyright even for simple configuration files like this one? I don't think this file could be copyrighted in my country because it is too simple. There are more complex files in scripts without any copyright: scripts/create_config scripts/hxtool scripts/make_device_config.sh scripts/qemu-binfmt-conf.sh If it is common understanding that every file should have a copyright, this rule should be added to CODING_STYLE. I don't mind adding a line "# public domain", nor do I mind if it is committed as it is. Regards, Stefan Weil PS. It might help some people if you would commit your emacs style, too.