From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4bBE-00039I-8z for qemu-devel@nongnu.org; Fri, 16 Sep 2011 12:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4bBD-0007KH-6G for qemu-devel@nongnu.org; Fri, 16 Sep 2011 12:22:20 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:51080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4bBC-0007K7-W2 for qemu-devel@nongnu.org; Fri, 16 Sep 2011 12:22:19 -0400 Received: by gye5 with SMTP id 5so3689198gye.4 for ; Fri, 16 Sep 2011 09:22:18 -0700 (PDT) Message-ID: <4E7377B7.1040109@codemonkey.ws> Date: Fri, 16 Sep 2011 11:22:15 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1316188834-13675-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1316188834-13675-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/14] qdev: assign unique names to all devices (part 1) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster , Jan Kiszka On 09/16/2011 11:00 AM, Anthony Liguori wrote: > This series introduces an infrastructure to remove anonymous devices from qdev. > Anonymous devices are one of the big gaps between qdev and QOM so removing is > a prerequisite to incrementally merging QOM. > > Besides the infrastructure, I also converted almost all of the possible PC > devices to have unique names. Please not that naming is not a property of > devices but rather of the thing that creates the devices (usually machines). > > The names are ugly but this is because of the alternating device/bus hierarchy > in qdev. For now, the names use '::' as deliminators but I think Jan has > convinced me that down the road, we should use '/' as a deliminator such that > the resulting names are actually valid paths (using a canonical path format). > > Here's a diffstat: apb_pci.c | 2 apic.c | 2 arm11mpcore.c | 4 - arm_sysctl.c | 2 armv7m.c | 6 +- axis_dev88.c | 8 +-- bonito.c | 2 collie.c | 2 cs4231a.c | 2 empty_slot.c | 2 escc.c | 4 - esp.c | 2 etraxfs.h | 2 fdc.c | 4 - fdc.h | 2 fw_cfg.c | 2 grackle_pci.c | 2 grlib.h | 6 +- gt64xxx.c | 2 gus.c | 2 i2c.c | 2 ide/isa.c | 2 ide/qdev.c | 3 - integratorcp.c | 21 +++++----- intel-hda.c | 2 isa-bus.c | 32 +++++++++++---- isa.h | 9 ++-- kvmclock.c | 2 lan9118.c | 2 lm32.h | 4 - lm32_boards.c | 14 +++--- m48t59.c | 4 - mainstone.c | 2 mc146818rtc.c | 2 milkymist-hw.h | 22 +++++----- mips_fulong2e.c | 2 mips_jazz.c | 4 - mips_malta.c | 2 mips_mipssim.c | 2 mips_r4k.c | 2 musicpal.c | 21 +++++----- nand.c | 2 nseries.c | 4 - omap1.c | 2 omap2.c | 2 pc.c | 15 +++---- pc.h | 12 ++--- pc_piix.c | 8 ++- pci.c | 35 +++++++++++----- petalogix_s3adsp1800_mmu.c | 2 piix_pci.c | 2 ppc_prep.c | 2 ppce500_mpc8544ds.c | 4 - pxa2xx.c | 24 +++++++---- pxa2xx_dma.c | 4 - pxa2xx_gpio.c | 2 pxa2xx_pic.c | 2 qdev.c | 94 +++++++++++++++++++++++++++++++++++++++------ qdev.h | 11 +++-- r2d.c | 4 - realview.c | 40 +++++++++---------- s390-virtio-bus.c | 2 s390-virtio.c | 4 - sb16.c | 2 scsi-bus.c | 2 sm501.c | 2 smbus_eeprom.c | 3 - smc91c111.c | 2 spapr_llan.c | 2 spapr_vio.c | 2 spapr_vscsi.c | 2 spapr_vty.c | 2 spitz.c | 8 +-- ssi.c | 2 stellaris.c | 14 +++--- strongarm.c | 17 ++++---- sun4m.c | 32 +++++++-------- sun4u.c | 6 +- syborg.c | 22 +++++----- sysbus.c | 67 +++++++++++++++++++++++++++++--- sysbus.h | 31 ++++++++------ tosa.c | 4 - unin_pci.c | 8 +-- usb-bus.c | 2 versatilepb.c | 34 ++++++++-------- vexpress.c | 28 ++++++------- xilinx.h | 10 ++-- 87 files changed, 490 insertions(+), 307 deletions(-) Regards, Anthony Liguori