From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5FaC-0005TA-Sy for qemu-devel@nongnu.org; Sun, 18 Sep 2011 07:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5FaB-0000F4-V3 for qemu-devel@nongnu.org; Sun, 18 Sep 2011 07:30:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5FaB-0000Eu-Fi for qemu-devel@nongnu.org; Sun, 18 Sep 2011 07:30:47 -0400 Message-ID: <4E75D663.1090707@redhat.com> Date: Sun, 18 Sep 2011 14:30:43 +0300 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 09/17/2011 10:28 PM, Blue Swirl wrote: > Since we use memory API in sun4u.c, after > 71579cae30b53c910cd6c47ab4e683f647d36519, setting up isa_mem_base > puts vga.chain4 outside of the physical address space. > > Fix by removing obsolete isa_mem_base set up. > > Signed-off-by: Blue Swirl > --- > hw/sun4u.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/sun4u.c b/hw/sun4u.c > index 32e6ab9..6afb0e7 100644 > --- a/hw/sun4u.c > +++ b/hw/sun4u.c > @@ -763,7 +763,6 @@ static void sun4uv_init(ram_addr_t RAM_size, > irq = qemu_allocate_irqs(cpu_set_irq, env, MAX_PILS); > pci_bus = pci_apb_init(APB_SPECIAL_BASE, APB_MEM_BASE, irq,&pci_bus2, > &pci_bus3); > - isa_mem_base = APB_PCI_IO_BASE; > pci_vga_init(pci_bus); Good catch, I wonder how many more such cases remain. I guess we should prioritize their conversion. -- error compiling committee.c: too many arguments to function