From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5N7b-0005n5-Dg for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:33:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5N7a-00088Y-Iq for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:33:47 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:42935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5N7a-000886-0W for qemu-devel@nongnu.org; Sun, 18 Sep 2011 15:33:46 -0400 Message-ID: <4E764792.4030407@reactos.org> Date: Sun, 18 Sep 2011 21:33:38 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1316357803-2366-1-git-send-email-hpoussin@reactos.org> <4E7644CE.9090509@web.de> In-Reply-To: <4E7644CE.9090509@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/11] ISA bus improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka a =C3=A9crit : > On 2011-09-18 16:56, Herv=C3=A9 Poussineau wrote: >> Following patches aim to change ISA bus to a first-citizen class in Qe= mu. >> >> They add ISA bus ops, like for scsi and usb buses. >> >> Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted >> to this new API, and a simple 'isabus-bridge' device is added. >> >> isa_address_space() operation can probably be used to remove the >> infamous isa_mem_base variable. However, some work is already done >> in this direction on the ML, so I didn't change anything. >> >> Finally, add bus argument to isa_create() functions, so architectures >> with multiple ISA buses (like some Alpha systems) can be emulated. >> >> As RFC didn't receive much comments, I put this serie as patches. >=20 > Nice work. I had something similar unfinished here, but this one looks > better on first glace. Thanks. >=20 > Still, I would go one step further and kill the global default isa_bus: > all ISA API user should pass in the bus they created and obtained from > some creator. >=20 That's indeed the next step I have in mind. It shouldn't be hard to do; that's mostly adding an isa_bus parameter in=20 all functions from ISA bridge creation to all ISA devices. However, lots=20 of prototypes will probably have to be changed, so I wanted to do it in=20 a second patchset. Herv=C3=A9