From: Bill Kendall <wkendall@sgi.com>
To: aelder@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: remove redundant error code mapping
Date: Mon, 19 Sep 2011 16:31:34 -0500 [thread overview]
Message-ID: <4E77B4B6.4080102@sgi.com> (raw)
In-Reply-To: <1316466127.2941.80.camel@doink>
On 09/19/2011 04:02 PM, Alex Elder wrote:
> On Fri, 2011-09-02 at 09:22 -0500, Bill Kendall wrote:
>> Currently there is both an exit_strings array and an exit_codestring()
>> function for mapping an exit code to a string. They are very similar
>> except the latter prefaces every string with "EXIT_" and the former
>> uses "SUCCESS" instead of "NORMAL", and cannot handle an invalid exit
>> code. exit_codestring() is not currently used in active code (it's for
>> multi-stream), so its values can be changed to allow the exit_strings
>> array to be removed.
>
> Looks good. You need to add your signoff on these things, i.e.:
> Signed-off-by: Bill Kendall<wkendall@sgi.com>
> We follow the signoff process used in the Linux kernel. See
> sections 12-14 in this document:
> https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches
>
>
> Reviewed-by: Alex Elder<aeldre@sgi.com>
>
Sorry, forgot the --signoff when formatting the patch. Need me to
resubmit?
Bill
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-19 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:22 [PATCH] xfsdump: remove redundant error code mapping Bill Kendall
2011-09-19 21:02 ` Alex Elder
2011-09-19 21:31 ` Bill Kendall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E77B4B6.4080102@sgi.com \
--to=wkendall@sgi.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.