From: Felix Fietkau <nbd@openwrt.org>
To: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH v2 2/4] ath9k_hw: clean up tx power handling
Date: Tue, 20 Sep 2011 00:22:55 +0200 [thread overview]
Message-ID: <4E77C0BF.50108@openwrt.org> (raw)
In-Reply-To: <CAB=NE6UzRhp=51QacoRzMPad0vO1qkNxK3=rayPuYXdjA3ZOJQ@mail.gmail.com>
On 2011-09-20 12:13 AM, Luis R. Rodriguez wrote:
> On Mon, Sep 19, 2011 at 3:12 PM, Luis R. Rodriguez
> <mcgrof@qca.qualcomm.com> wrote:
>> On Mon, Sep 19, 2011 at 3:04 PM, Felix Fietkau<nbd@openwrt.org> wrote:
>>> On 2011-09-19 11:54 PM, Luis R. Rodriguez wrote:
>>>>
>>>> On Mon, Sep 19, 2011 at 2:45 PM, Luis R. Rodriguez
>>>> <mcgrof@qca.qualcomm.com> wrote:
>>>>>
>>>>> On Mon, Sep 19, 2011 at 2:21 PM, Felix Fietkau<nbd@openwrt.org> wrote:
>>>>>>
>>>>>> I looked at the other ath driver and I see no indication that it's
>>>>>> related
>>>>>> to DFS in any way.
>>>>>
>>>>> I have verified this just now as well, it seems it was only used to
>>>>> support an ioctl to userspace to enable users to update a tpscale
>>>>> value but I see no documentation about this. Next question is who in
>>>>> usersapce sets this. I wonder if its done through userspace after
>>>>> measuring some TPC reports from STAs.
>>>>
>>>> So this comes from supporting a "TR-098" specification, which seems to
>>>> be the "Internet Gateway Device data model for the CPE WAN Management
>>>> Protocol". I haven't yet been able to map this to the specification
>>>> respective component:
>>>>
>>>> http://www.broadband-forum.org/technical/download/TR-098.pdf
>>>
>>> Interesting. That definitely supports my point that ath9k is the wrong place
>>> for something like this to be. Let's just get rid of it.
>>
>> Yeah, I'm now convinced :) die code. But please do add some blurb
>> about this tumor the code had.
>
> In fact removing the tumor through a separate patch would be appreciated.
I don't think it needs a separate patch. It's dead code directly related
to the other things that I'm changing, and it does not add any
functional changes. I'll add a comment, though.
- Felix
next prev parent reply other threads:[~2011-09-19 22:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 17:38 [PATCH v2 1/4] ath9k_hw: make ath9k_hw_set_interrupts use ah->imask by default Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 2/4] ath9k_hw: clean up tx power handling Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 4/4] ath9k_hw: remove EEP_REG_1 Felix Fietkau
2011-09-19 18:18 ` [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext Luis R. Rodriguez
2011-09-19 18:29 ` Felix Fietkau
2011-09-19 18:43 ` Luis R. Rodriguez
2011-09-19 18:56 ` Felix Fietkau
2011-09-19 18:58 ` Luis R. Rodriguez
2011-09-19 19:03 ` Felix Fietkau
2011-09-19 20:29 ` John W. Linville
2011-09-19 18:30 ` [PATCH v2 2/4] ath9k_hw: clean up tx power handling Felix Fietkau
2011-09-19 20:41 ` Luis R. Rodriguez
2011-09-19 20:50 ` Felix Fietkau
2011-09-19 21:14 ` Luis R. Rodriguez
2011-09-19 21:21 ` Felix Fietkau
2011-09-19 21:45 ` Luis R. Rodriguez
2011-09-19 21:54 ` Luis R. Rodriguez
2011-09-19 22:04 ` Felix Fietkau
2011-09-19 22:12 ` Luis R. Rodriguez
2011-09-19 22:13 ` Luis R. Rodriguez
2011-09-19 22:22 ` Felix Fietkau [this message]
2011-09-20 2:45 ` Adrian Chadd
2011-09-19 22:02 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E77C0BF.50108@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.