From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5vfp-0004Rg-2Y for qemu-devel@nongnu.org; Tue, 20 Sep 2011 04:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5vfk-0001aI-Fn for qemu-devel@nongnu.org; Tue, 20 Sep 2011 04:27:25 -0400 Received: from thoth.sbs.de ([192.35.17.2]:21823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5vfk-0001ZV-0o for qemu-devel@nongnu.org; Tue, 20 Sep 2011 04:27:20 -0400 Message-ID: <4E784E63.3050404@siemens.com> Date: Tue, 20 Sep 2011 10:27:15 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1316361891-8960-1-git-send-email-hpoussin@reactos.org> <4E76F5F2.7000204@siemens.com> <4E778EB7.5010706@reactos.org> In-Reply-To: <4E778EB7.5010706@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: "qemu-devel@nongnu.org" On 2011-09-19 20:49, Herv=C3=A9 Poussineau wrote: > Jan Kiszka a =C3=A9crit : >> On 2011-09-18 18:04, Herv=C3=A9 Poussineau wrote: >>> Signed-off-by: Herv=C3=A9 Poussineau >>> --- >>> hw/pc_piix.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>> index da6fa55..c0b8a3a 100644 >>> --- a/hw/pc_piix.c >>> +++ b/hw/pc_piix.c >>> @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory, >>> pc_memory_init(system_memory, >>> kernel_filename, kernel_cmdline, initrd_filen= ame, >>> below_4g_mem_size, above_4g_mem_size, >>> - pci_memory, &ram_memory); >>> + pci_enabled ? pci_memory : system_memory, &ra= m_memory); >>> } >>> =20 >>> if (!xen_enabled()) { >> >> Makes sense. I guess we should rename 'pci_memory' inside pc_memory_in= it >> to reflect this - 'rom_memory'? >> >> But -M isapc still only gives me a black screen. Are there further fix= es >> required? >> >=20 > Yes, you also need to rollback pc-bios/bios.bin to previous version (ie= =20 > 8b06c62ae48b67b320f7420dcd4854c5559e1532) Did you already try to bisect that probable regression in SeaBIOS? Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux