From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows
Date: Tue, 20 Sep 2011 13:20:44 +0300 [thread overview]
Message-ID: <4E7868FC.7040407@redhat.com> (raw)
In-Reply-To: <1315561022-25386-1-git-send-email-stefanha@linux.vnet.ibm.com>
On 09/09/2011 12:37 PM, Stefan Hajnoczi wrote:
> The 'simple' trace backend uses pthreads and does not work on Windows. These
> patches switch from pthreads to glib so that the code builds on all platforms
> supported by glib.
>
> Only one thing I'm unhappy about: the simpletrace write-out thread used to
> block all signals. I have removed that code and don't expect glib to do it for
> me. I'm not sure if there is a problem if signal handlers are invoked in the
> write-out thread instead of a QEMU thread. Any thoughts?
>
Yes it's a problem when we block a signal completely and only process it
with sigtimedwait().
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-09-20 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 9:37 [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows Stefan Hajnoczi
2011-09-09 9:37 ` [Qemu-devel] [PATCH 1/2] trace: portable simple trace backend using glib Stefan Hajnoczi
2011-09-20 10:31 ` Jan Kiszka
2011-09-20 10:52 ` Paolo Bonzini
2011-09-20 10:58 ` Jan Kiszka
2011-09-20 12:01 ` Stefan Hajnoczi
2011-09-09 9:37 ` [Qemu-devel] [PATCH 2/2] trace: use binary file open mode in simpletrace Stefan Hajnoczi
2011-09-09 11:12 ` [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows Paolo Bonzini
2011-09-20 9:05 ` hkran
2011-09-20 9:57 ` Stefan Hajnoczi
2011-09-20 10:15 ` Zhi Yong Wu
2011-09-23 5:58 ` hkran
2011-09-20 10:20 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7868FC.7040407@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.