Re: [PATCH v2] libroxml: Add version 2.1.0

[Tristan Lelong <tristan.lelong@blunderer.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I corrected the other problems with my recipe and I'm about to submit it
again.
There is only one point I don't understand:

"Please add how you tested this package with."


What do you mean by tested? you want the openembedded distro, toolchain,
version (git hash)? the full local.conf? the software internal tests?
anything else?

Thank you very much for your time.


Le 18/09/2011 12:26, Paul Menzel a écrit :
> Dear Tristan,
>
>
> thank you for updating the patch.
>
> Am Mittwoch, den 14.09.2011, 17:00 +0200 schrieb
tristan.lelong@blunderer.org:
>> From: Tristan Lelong <tristan.lelong@blunderer.org>
>>
>> libroxml is a small fast and powerful xml library
>
> Please add how you tested this package with.
>
>> Signed-off-by: Tristan Lelong <tristan.lelong@blunderer.org>
>> ---
>> recipes/libroxml/libroxml.inc | 19 +++++++++++++++++++
>> recipes/libroxml/libroxml_2.1.0.bb | 6 ++++++
>> 2 files changed, 25 insertions(+), 0 deletions(-)
>> create mode 100644 recipes/libroxml/libroxml.inc
>> create mode 100644 recipes/libroxml/libroxml_2.1.0.bb
>>
>> diff --git a/recipes/libroxml/libroxml.inc b/recipes/libroxml/libroxml.inc
>> new file mode 100644
>> index 0000000..06322fe
>> --- /dev/null
>> +++ b/recipes/libroxml/libroxml.inc
>> @@ -0,0 +1,19 @@
>> +DESCRIPTION = "Small, fast and powerful xml library"
>> +AUTHOR = "Tristan Lelong <tristan.lelong@libroxml.net>"
>> +HOMEPAGE = "http://www.libroxml.net"
>> +SECTION = "libs"
>> +PRIORITY = "optional"
>> +INC_PR = "r0"
>> +LICENSE = "LGPL"
>
> Please order according to the style guide [1].
>
> Additionally checking the license this contradicts itself. `LGPL.txt`
> actually says version 3 or later, but the header in the the source files
> like `roxml.c` says LGPL 2.1 or later.
>
> Please clarify that in the source as you are the upstream author.
> Additionally please never release a new source archive without changing
> the version number. This causes problems when checksums are used as in
> OE.
>
>> +
>> +SRC_URI = "http://libroxml.googlecode.com/files/libroxml-2.1.0.tar.gz"
>
> Please use `${P}` instead of `libroxml-2.1.0`.
>
>> +
>> +inherit pkgconfig
>
> You do not ship any pkg-config file.
>
>> +
>> +do_install() {
>> + oe_runmake install DESTDIR=${D}
>> +}
>> +
>> +PACKAGES= ${PN} roxml
>> +FILES_${PN} = ${libdir}/libroxml.so.0
>> +FILES_roxml = ${bindir}/roxml
>
> Why do you need to define that manually?
>
> NOTE: package libroxml-2.1.0-r0.0: task do_qa_staging: Started
> WARNING: the following files were installed but not shipped in any package:
> WARNING: /usr/lib/libroxml.so
> WARNING: /usr/lib/libroxml.a
> WARNING: /usr/lib/pkgconfig/libroxml.pc
> WARNING: /usr/lib/.debug/libroxml.so.0
> WARNING: /usr/include/roxml.h
> WARNING: /usr/share/man/man1/roxml.1
> WARNING: /usr/share/doc/libroxml/LGPL.txt
> WARNING: /usr/bin/.debug/roxml
>
>> diff --git a/recipes/libroxml/libroxml_2.1.0.bb
b/recipes/libroxml/libroxml_2.1.0.bb
>> new file mode 100644
>> index 0000000..b3669e1
>> --- /dev/null
>> +++ b/recipes/libroxml/libroxml_2.1.0.bb
>> @@ -0,0 +1,6 @@
>> +PR = "${INC_PR}.0"
>> +
>> +SRC_URI[md5sum] = "ad1903efa241914baec2fd432a176549"
>> +SRC_URI[sha256sum] =
"bf2d908c330e28e5470fe9a841438b78025dc1406742fc54aad6fa8db401229a"
>> +
>> +require libroxml.inc
>
> I think `require libroxml.inc` should go to the beginning.
>
>
> Thanks,
>
> Paul
>
>
> [1] http://openembedded.org/index.php?title=Styleguide


- -- 
618FE3EF
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk54pLoACgkQFj9oxGGP4+8AEACfXMzlV4KATxgZ8SPMHD57bS4T
VYUAn3IVRTqIhDCFHr8faJmHRBRzL9Zg
=7Egn
-----END PGP SIGNATURE-----