From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() Date: Tue, 20 Sep 2011 14:38:03 -0400 Message-ID: <4E78DD8B.1020605@redhat.com> References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Johannes Weiner , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: In-Reply-To: <20110920142553.GA2593@infradead.org> List-ID: On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > In addition to regular write shouldn't __do_fault and do_wp_page also > calls this if they are called on file backed mappings? > Probably not do_wp_page since it always creates an anonymous page, which are not very relevant to the dirty page cache accounting. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8KIcH8w076600 for ; Tue, 20 Sep 2011 13:38:17 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 412AF1403C0C for ; Tue, 20 Sep 2011 11:43:36 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id DxEUICaHQ4L3bNSG for ; Tue, 20 Sep 2011 11:43:36 -0700 (PDT) Message-ID: <4E78DD8B.1020605@redhat.com> Date: Tue, 20 Sep 2011 14:38:03 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> In-Reply-To: <20110920142553.GA2593@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: linux-ext4@vger.kernel.org, Jan Kara , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-mm@kvack.org, Andreas Dilger , Mel Gorman , linux-fsdevel@vger.kernel.org, Theodore Ts'o , Andrew Morton , Wu Fengguang , Johannes Weiner , Chris Mason , Minchan Kim On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > In addition to regular write shouldn't __do_fault and do_wp_page also > calls this if they are called on file backed mappings? > Probably not do_wp_page since it always creates an anonymous page, which are not very relevant to the dirty page cache accounting. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812Ab1ITSin (ORCPT ); Tue, 20 Sep 2011 14:38:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27877 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab1ITSik (ORCPT ); Tue, 20 Sep 2011 14:38:40 -0400 Message-ID: <4E78DD8B.1020605@redhat.com> Date: Tue, 20 Sep 2011 14:38:03 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Christoph Hellwig CC: Johannes Weiner , Andrew Morton , Mel Gorman , Dave Chinner , Wu Fengguang , Jan Kara , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin() References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-4-git-send-email-jweiner@redhat.com> <20110920142553.GA2593@infradead.org> In-Reply-To: <20110920142553.GA2593@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > In addition to regular write shouldn't __do_fault and do_wp_page also > calls this if they are called on file backed mappings? > Probably not do_wp_page since it always creates an anonymous page, which are not very relevant to the dirty page cache accounting.