From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R65QZ-0001op-9W for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R65QY-0002tp-5b for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:52:19 -0400 Received: from mail-gw0-f47.google.com ([74.125.83.47]:64012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R65QY-0002tj-12 for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:52:18 -0400 Received: by gwaa2 with SMTP id a2so885949gwa.6 for ; Tue, 20 Sep 2011 11:52:16 -0700 (PDT) Message-ID: <4E78E0DC.2050303@codemonkey.ws> Date: Tue, 20 Sep 2011 13:52:12 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4E78D516.7080803@redhat.com> In-Reply-To: <4E78D516.7080803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH] qemu: Fix shutdown regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, QEMU Developers On 09/20/2011 01:01 PM, Eric Blake wrote: > On 09/20/2011 11:39 AM, Jiri Denemark wrote: >> The commit that prevents disk corruption on domain shutdown >> (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU >> 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed >> only recently in QEMU git. With affected QEMU binaries, domains cannot >> be shutdown properly and stay in a paused state. This patch tries to >> avoid this by sending SIGKILL to 0.1[45].* QEMU processes. Though we >> wait a bit more between sending SIGTERM and SIGKILL to reduce the >> possibility of virtual disk corruption. >> --- >> src/qemu/qemu_capabilities.c | 7 +++++++ >> src/qemu/qemu_capabilities.h | 1 + >> src/qemu/qemu_process.c | 19 +++++++++++++------ >> 3 files changed, 21 insertions(+), 6 deletions(-) > > ACK. But it would be nice if upstream qemu could give us a more reliable > indication of whether the qemu SIGTERM bug is fixed, so that we don't corrupt > data on a patched 0.14 or 0.15 qemu. Can you be a lot more specific about what bug you mean? > That is, as part of fixing the bug in qemu, > we should also update -help text or something similar, so that libvirt can avoid > making decisions solely on version numbers. The version number *is* the right way to make decisions. We've gone through this dozens of times. The fact that distros backport all sorts of stuff means that you need to maintain a matrix of versions with features. It's not our (upstream QEMU's) responsibility to tell you the differences that exist in forks of QEMU. Regards, Anthony Liguori