From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R6H7b-00050Y-Gc
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:21:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R6H7Z-0000xl-VU
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:21:31 -0400
Received: from david.siemens.de ([192.35.17.14]:34120)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R6H7Z-0000xf-Jp
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:21:29 -0400
Message-ID: <4E799076.8050501@siemens.com>
Date: Wed, 21 Sep 2011 09:21:26 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <20110920190601.31721.9457.stgit@ginnungagap.bsc.es>
In-Reply-To: <20110920190601.31721.9457.stgit@ginnungagap.bsc.es>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] trace: Add "vcpu_init" event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= <vilanova@ac.upc.edu>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2011-09-20 21:06, Llu=C3=ADs Vilanova wrote:
> Signals the creation of a new vCPU (CPUState structure).
>=20
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  cpus.c        |    1 +
>  qemu-common.h |    4 +++-
>  trace-events  |    7 +++++++
>  3 files changed, 11 insertions(+), 1 deletions(-)
>=20
> diff --git a/cpus.c b/cpus.c
> index 54c188c..ab699bb 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -861,6 +861,7 @@ void qemu_init_vcpu(void *_env)
>      } else {
>          qemu_tcg_init_vcpu(env);
>      }
> +    trace_vcpu_init(env);
>  }
> =20
>  void qemu_notify_event(void)
> diff --git a/qemu-common.h b/qemu-common.h
> index 404c421..511f0c7 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -296,8 +296,10 @@ struct qemu_work_item {
>      int done;
>  };
> =20
> +#include "trace.h"
> +
>  #ifdef CONFIG_USER_ONLY
> -#define qemu_init_vcpu(env) do { } while (0)
> +#define qemu_init_vcpu(env) do { trace_vcpu_init(env); } while (0)

As you are already at it, please make this a proper static inline
instead of a macro.

Both patches look good otherwise.

Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux