From: Paolo Bonzini <pbonzini@redhat.com>
To: Brad <brad@comstyle.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.
Date: Wed, 21 Sep 2011 09:32:13 +0200 [thread overview]
Message-ID: <4E7992FD.4060207@redhat.com> (raw)
In-Reply-To: <4E7991FE.9010204@comstyle.com>
On 09/21/2011 09:27 AM, Brad wrote:
> Besides the obvious issue..
>
> nbd.c:443: error: conflicting types for 'nbd_init'
> nbd.h:71: error: previous declaration of 'nbd_init' was here
Oops, thanks for pointing it out to me.
> The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also
> looks questionable to me.
It is not portable code, and (unlike the rest of qemu-nbd and the
block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined
in linux/fs.h) and the whole set of NBD ioctls available under OpenBSD?
Paolo
next prev parent reply other threads:[~2011-09-21 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 7:27 [Qemu-devel] Tree broken by nbd: support feature negotiation commit Brad
2011-09-21 7:32 ` Paolo Bonzini [this message]
2011-09-21 7:42 ` Kevin Wolf
2011-09-21 7:43 ` Brad
2011-09-21 9:21 ` Paolo Bonzini
2011-09-21 9:23 ` Brad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7992FD.4060207@redhat.com \
--to=pbonzini@redhat.com \
--cc=brad@comstyle.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.