From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HTF-00028X-6X for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6HTE-00068T-2T for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:43:53 -0400 Received: from speedy.comstyle.com ([206.51.28.2]:11416 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HTD-00068P-T1 for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:43:52 -0400 Message-ID: <4E7995B3.3030106@comstyle.com> Date: Wed, 21 Sep 2011 03:43:47 -0400 From: Brad MIME-Version: 1.0 References: <4E7991FE.9010204@comstyle.com> <4E7992FD.4060207@redhat.com> In-Reply-To: <4E7992FD.4060207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , qemu-devel On 21/09/11 3:32 AM, Paolo Bonzini wrote: > On 09/21/2011 09:27 AM, Brad wrote: >> Besides the obvious issue.. >> >> nbd.c:443: error: conflicting types for 'nbd_init' >> nbd.h:71: error: previous declaration of 'nbd_init' was here > > Oops, thanks for pointing it out to me. > >> The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also >> looks questionable to me. > > It is not portable code, and (unlike the rest of qemu-nbd and the > block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in > linux/fs.h) and the whole set of NBD ioctls available under OpenBSD? Ok. What confused me a bit is that particular code path before your commit was being built on anything but Windows but is now Linux only. No we don't have BLKROSET. So am I to understand that even before this particular commit that this code was only supported on Linux? I honestly have no familiarity with NBD. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.