Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

Hi Laurent,

On 09/21/2011 12:23 AM, Laurent Pinchart wrote:
> On Monday 19 September 2011 13:26:39 Sylwester Nawrocki wrote:
>> On 09/19/2011 08:08 AM, Subash Patel wrote:
>>> Hi Laurent,
>>>
>>> I am not representing Sylwester :), But with a similar sensor I use, Aqua
>>> means cool tone which is Cb/Cr manipulations.
>>>
>>> On 09/19/2011 04:38 AM, Laurent Pinchart wrote:
>>>> On Friday 16 September 2011 19:05:28 Sylwester Nawrocki wrote:
>>>>> Add V4L2_COLORFX_AQUA image effect in the V4L2_CID_COLORFX menu.
>>>>
>>>> What's the aqua effect ?
>>
>> Aqua means cool tone, as Subash explained. It's somehow opposite to Sepia
>> which is warm tone. I'll improve the commit description in the next patch
>> version.
>> I tried to make a table with short description of each color effect in the
>> DocBook but it was taking me too long so I dropped it for a moment.
>>
>> I have attached an image presenting the color effects. Maybe it's worth
>> to add something like this to the DocBook, or perhaps just the
>> descriptions.
> 
> Thanks for the information. I think it would indeed be useful to add 
> descriptions to the documentation.

Sure, I'll try to find some time to complete this. And I wonder, what BLUE_SKY
effect is ? I suspect it's very much same as the Aqua effect which is present
in our sensor ISP. Does anyone know exactly ? Perhaps I could just use it
instead of adding new menu entry.

Regards,
-- 
Sylwester Nawrocki
Samsung Poland R&D Center