From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 8/7][retry remove] Also add check for filesystem use on a DM/LVM device - "dm_device_has_fs"
Date: Wed, 21 Sep 2011 10:55:41 +0200 [thread overview]
Message-ID: <4E79A68D.1080702@redhat.com> (raw)
In-Reply-To: <4E78F101.7090907@redhat.com>
On 09/20/2011 10:01 PM, Zdenek Kabelac wrote:
> How bad would be to replace the code in lvremove with something like:
> when remove fails - call system("udevadm settle") - and retry whole
> lv_remove_with_depenencies() (or whatever baselevel we pick here).
This solution was nacked already, please do not reiterate it again.
Avoid system() in any case, whatever command it is.
> PS: easiest workaround for failing lvremove is - to replace lvremove with
> shell wrapper which call udevadm settle and retries lvremove in case the first
> one fails.
Yes, and all system security audit log will point to lvm. Please do not do
such home made solutions. This need proper solution and no such things.
Milan
next prev parent reply other threads:[~2011-09-21 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 19:15 [PATCH 8/7][retry remove] Also add check for filesystem use on a DM/LVM device - "dm_device_has_fs" Peter Rajnoha
2011-09-20 20:01 ` Zdenek Kabelac
2011-09-21 8:55 ` Milan Broz [this message]
2011-09-21 10:22 ` Zdenek Kabelac
2011-09-21 8:39 ` Peter Rajnoha
2011-09-21 11:39 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79A68D.1080702@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.