From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1R6IsC-0004mk-0I
	for mharc-grub-devel@gnu.org; Wed, 21 Sep 2011 05:13:44 -0400
Received: from eggs.gnu.org ([140.186.70.92]:51245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R6Is8-0004lR-Sd
	for grub-devel@gnu.org; Wed, 21 Sep 2011 05:13:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R6Is4-0008IH-WF
	for grub-devel@gnu.org; Wed, 21 Sep 2011 05:13:40 -0400
Received: from mail-wy0-f180.google.com ([74.125.82.180]:39567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R6Is4-0008IC-Oh
	for grub-devel@gnu.org; Wed, 21 Sep 2011 05:13:36 -0400
Received: by wyj26 with SMTP id 26so2486828wyj.39
	for <grub-devel@gnu.org>; Wed, 21 Sep 2011 02:13:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:subject:references
	:in-reply-to:content-type:content-transfer-encoding;
	bh=xLDOgR2ATUI1GX3R7bXrAOI+egpDCVPry09LN0g+YsY=;
	b=disBRy41sKxH0JMJ0TdrxrReSS6Q/fbV/fIKRFUieAihOWEnpjDO7z24hDm4Lz0YQ/
	DtgYKEgQ8Dl1UCz/V+BPChYGeQrqBmHCPXSRlA12sZ2Pb1gszJIyQe4yz661w7xWpiBM
	d7DZk6ouIFgpX9d9Bbe11CQbjXR+ZA8RPeMOY=
Received: by 10.227.28.17 with SMTP id k17mr472027wbc.3.1316596415072;
	Wed, 21 Sep 2011 02:13:35 -0700 (PDT)
Received: from [192.168.1.37] (c2433-1-88-160-112-182.fbx.proxad.net.
	[88.160.112.182])
	by mx.google.com with ESMTPS id j18sm6108864wbo.6.2011.09.21.02.13.33
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 21 Sep 2011 02:13:34 -0700 (PDT)
Message-ID: <4E79AABD.3020306@gmail.com>
Date: Wed, 21 Sep 2011 11:13:33 +0200
From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= <gregoire.sutre@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13
MIME-Version: 1.0
To: grub-devel@gnu.org
Subject: Re: [patch] Make knetbsd pass the root device
References: <4E7920D0.3090401@gmail.com>
In-Reply-To: <4E7920D0.3090401@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.180
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2011 09:13:42 -0000

On 09/21/2011 01:25 AM, Grégoire Sutre wrote:
> +  dev = grub_device_open (0);
> +  if (! (dev&&  dev->disk&&  dev->disk->partition))
> +    return;

This `return' should be a `goto fail'.

Grégoire