From: Dave Aldridge <fovsoft@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] ns16550: change to allow 32 bit access to registers
Date: Wed, 21 Sep 2011 10:27:37 +0100 [thread overview]
Message-ID: <4E79AE09.1030301@gmail.com> (raw)
In-Reply-To: <20110907213623.08733140875D@gemini.denx.de>
Hi Wolfgang
On 07/09/11 22:36, Wolfgang Denk wrote:
> Dear Dave Aldridge,
>
> In message <1314953234-3977-1-git-send-email-fovsoft@gmail.com> you wrote:
>> If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory
>> mapped access will be used to read/write the uart registers.
> ...
>> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE > 0)
>> +#define serial_out(x,y) out_be32(y,x)
>> +#define serial_in(y) in_be32(y)
>> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE < 0)
>
> Please see comment to previous version.
I think the discussions in the '[U-Boot] [PATCH v3] ns16550:' confirm the above
usage of the _REG_SIZE macro for determining the endianess of the uart is correct.
I can also confirm that the patch does work for me.
Cheers
Dave
next prev parent reply other threads:[~2011-09-21 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 8:47 [U-Boot] [PATCH v4] ns16550: change to allow 32 bit access to registers Dave Aldridge
2011-09-07 21:36 ` Wolfgang Denk
2011-09-21 9:27 ` Dave Aldridge [this message]
2011-10-01 19:54 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79AE09.1030301@gmail.com \
--to=fovsoft@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.