From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/11] at91/boards: use -1 for invalid gpio
Date: Wed, 21 Sep 2011 11:28:36 +0200 [thread overview]
Message-ID: <4E79AE44.3070006@atmel.com> (raw)
In-Reply-To: <1316436695-19194-2-git-send-email-plagnioj@jcrosoft.com>
Le 19/09/2011 14:51, Jean-Christophe PLAGNIOL-VILLARD :
> this will allow to use gpio_is_valid
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
[..]
> ---
> 34 files changed, 141 insertions(+), 50 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-1arm.c b/arch/arm/mach-at91/board-1arm.c
> index 5aa5885..17d9163 100644
> --- a/arch/arm/mach-at91/board-1arm.c
> +++ b/arch/arm/mach-at91/board-1arm.c
> @@ -70,6 +70,7 @@ static struct at91_eth_data __initdata onearm_eth_data = {
>
> static struct at91_usbh_data __initdata onearm_usbh_data = {
> .ports = 1,
> + .vbus_pin = {-1, -1},
I would prefer to use "-EINVAL" as stated in the documentation.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2011-09-21 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 12:51 [PATCH 01/11] at91/gpio: make gpio register base soc independant Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 12:51 ` [PATCH 02/11] at91/boards: use -1 for invalid gpio Jean-Christophe PLAGNIOL-VILLARD
2011-09-21 9:28 ` Nicolas Ferre [this message]
2011-09-19 12:51 ` [PATCH 03/11] at91/soc: use gpio_is_valid to check the gpio Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 12:51 ` [PATCH 04/11] at91/pata: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 12:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 12:51 ` [PATCH 05/11] at91/ide: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 12:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` [PATCH 06/11] at91/mmc: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` [PATCH 07/11] at92/nand: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` [PATCH 08/11] at92/udc: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-20 9:52 ` Sebastian Andrzej Siewior
2011-09-19 14:03 ` [PATCH 09/11] at92/ohci: " Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` [PATCH 10/11] at91/gpio: drop PIN_BASE Jean-Christophe PLAGNIOL-VILLARD
2011-09-19 14:03 ` [PATCH 11/11] at91/gpio: fix display of number of irq setuped Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79AE44.3070006@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.