All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ASoC: Staticise jz4740_pcm_new()
Date: Wed, 21 Sep 2011 16:09:18 +0200	[thread overview]
Message-ID: <4E79F00E.7030306@metafoo.de> (raw)
In-Reply-To: <1316587310.2824.3.camel@phoenix>

On 09/21/2011 08:41 AM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>  sound/soc/jz4740/jz4740-pcm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
> index a7c9578..d1989cd 100644
> --- a/sound/soc/jz4740/jz4740-pcm.c
> +++ b/sound/soc/jz4740/jz4740-pcm.c
> @@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm)
>  
>  static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
>  
> -int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
> +static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
>  {
>  	struct snd_card *card = rtd->card->snd_card;
>  	struct snd_soc_dai *dai = rtd->cpu_dai;

  reply	other threads:[~2011-09-21 14:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  6:40 [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Axel Lin
2011-09-21  6:40 ` [PATCH 2/4] ASoC: Staticise bf5xx_pcm_i2s_new() Axel Lin
2011-09-21  6:41 ` [PATCH 3/4] ASoC: Staticise jz4740_pcm_new() Axel Lin
2011-09-21 14:09   ` Lars-Peter Clausen [this message]
2011-09-21  6:42 ` [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition() Axel Lin
2011-09-21  6:49   ` Wan ZongShun
2011-09-21  6:49     ` Wan ZongShun
2011-09-21 13:56 ` [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Mark Brown
2011-09-21 13:56   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E79F00E.7030306@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.