Re: [PATCH 0/2] Disable functionality that doesn't work on MINGW32

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

On 21.09.2011 23:29, Mario Limonciello wrote:
> The following two patches are for disabling some specifics that will
> not work on MINGW32.
>
> Vladimir explicitly expressed disinterest in going the route of #undef
> GRUB_UTIL, but it seems to be the most appropriate method in the first
> patch to me because MINGW32 does not support ttys and won't ever.
>
GRUB_UTIL means that we run under an OS and use it. While Windows is a
low-quality one, it's still one, so GRUB_UTIL must be defined. Correct
way to dial with this issue is to add a windows equivalent of this code
(requesting password from user).
> The second patch just matches other code, since there is no
> grub_util_get_fd_sectors defined on MINGW32.  This will at least get
> the file compiling with potentially broken functionality, which I see
> as an improvement over not compiling and no functionality.
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]