From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1R6Uxo-0002jT-C2 for mharc-grub-devel@gnu.org; Wed, 21 Sep 2011 18:08:20 -0400 Received: from eggs.gnu.org ([140.186.70.92]:60549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Uxm-0002ib-8t for grub-devel@gnu.org; Wed, 21 Sep 2011 18:08:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6Uxl-0005sw-70 for grub-devel@gnu.org; Wed, 21 Sep 2011 18:08:18 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:39376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Uxl-0005si-2X for grub-devel@gnu.org; Wed, 21 Sep 2011 18:08:17 -0400 Received: by fxh17 with SMTP id 17so2435796fxh.0 for ; Wed, 21 Sep 2011 15:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=54SjhrNOhu7Ju2NfP+JIiXxF3b1Qsh1veFiLr9k3B9Q=; b=bOXmFyFJcSgSV2QI9izMO9vdZi72E+4PpzE1wcvyBQtP2UncH27LjssL3QmkvgVTh2 43jawdCj2Xwrrmn03rmaGecnr3f8AdtxAcLe9A0PeRZZSsuQ+BFcehVmmWqm2NEacwa5 XGoFaSMR26RQth5lKki41u54rrvkkFLBk7ziM= Received: by 10.223.10.84 with SMTP id o20mr1808239fao.25.1316642896412; Wed, 21 Sep 2011 15:08:16 -0700 (PDT) Received: from debian.x201.phnet (gprs17.swisscom-mobile.ch. [193.247.250.17]) by mx.google.com with ESMTPS id m26sm5530626fac.6.2011.09.21.15.08.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Sep 2011 15:08:15 -0700 (PDT) Message-ID: <4E7A604C.3090308@gmail.com> Date: Thu, 22 Sep 2011 00:08:12 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH 2/2] Disable unsupported grub_util_get_fd_sectors in geli on MINGW32 References: <4E7A574D.5000606@dell.com> In-Reply-To: <4E7A574D.5000606@dell.com> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigAFEB382C8FF4FEED70FB9C51" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2011 22:08:19 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAFEB382C8FF4FEED70FB9C51 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21.09.2011 23:29, Mario Limonciello wrote: > +#if !defined(__MINGW32__) > s =3D grub_util_get_fd_sectors (fd, &log_secsize); > grub_util_fd_seek (fd, dev, (s << log_secsize) - 512); > +#endif This would make GRUB behave erratically if this code is ever reached which is always a bad thing. While doing something like #if defined (GRUB_UTIL) && ! defined (__MINGW32__) on whole function is a cheap and functionality-reducing way to port, correct way is to add a windows equivalent of this call (getting disk/file size) --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigAFEB382C8FF4FEED70FB9C51 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk56YEwACgkQNak7dOguQglYnAD/RN6r7hzrXz7WPq6mBQoCxuuE NTJOQ/vMjcg+BOe9issA/2NjmdtmQzFomeAy04R7Ca/Etd85Etttsn59Q3xEsis/ =Mk1b -----END PGP SIGNATURE----- --------------enigAFEB382C8FF4FEED70FB9C51--