From: Wolfgang Grandegger <wg@grandegger.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: SocketCAN Core Mailing List <socketcan-core@lists.berlios.de>,
Willy Lambert <lambert.willy@gmail.com>,
x86@kernel.org, Valdis.Kletnieks@vt.edu,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: permit to configure ISA support also for x86_64 systems
Date: Thu, 22 Sep 2011 08:43:20 +0200 [thread overview]
Message-ID: <4E7AD908.8060101@grandegger.com> (raw)
In-Reply-To: <11382509.BgAkVknI9a@wuerfel>
On 09/21/2011 11:24 AM, Arnd Bergmann wrote:
> On Wednesday 21 September 2011 10:33:10 Wolfgang Grandegger wrote:
>>
>>> Since most ISA drivers don't actually use isa_register_driver
>>> (for good or bad), how about changing the Kconfig entry for
>>> the ones you need to 'depends on ISA || PLAT_GRANDEGGER_PC104_ATOM'
>>> or similar?
>>
>> What should the PLAT_GRANDEGGER_PC104_ATOM be good for? If I replace
>> isa_register_driver() with platform_driver_register(), like the serial
>> 8250 driver does, HAS_IOMEM should be just fine. This would then also
>> avoid the 64-bit trouble expected with old ISA drivers (enabled via
>> ISA). Or have I missed something?
>
> I was thinking of the drivers that are for ISA cards but don't actually
> use the isa_register_driver() function. If you have to change the driver
> to a platform driver, you are right.
OK, then I will finally convert the sja1000_isa driver to a platform
driver instead of allowing CONFIG_ISA for x86_64.
> The other point is that you are probably using inb/outb operations,
> which I'm trying to provide only on ISA/PCMCIA/PCI based systems in
> the future. Once I finish that work, you will also need to depend on
> HAS_IOPORT (which currently means something else).
OK, the sja1000_isa driver just uses memory mapped access.
Wolfgang.
next prev parent reply other threads:[~2011-09-22 6:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 9:22 [PATCH] x86_64: permit to configure ISA support also for x86_64 systems Wolfgang Grandegger
2011-09-16 19:19 ` Valdis.Kletnieks
2011-09-16 19:31 ` Wolfgang Grandegger
2011-09-20 15:47 ` Arnd Bergmann
2011-09-21 8:33 ` Wolfgang Grandegger
2011-09-21 9:24 ` Arnd Bergmann
2011-09-21 22:13 ` Andi Kleen
2011-09-22 6:43 ` Wolfgang Grandegger [this message]
2011-09-22 14:20 ` Arnd Bergmann
2011-09-22 14:57 ` Wolfgang Grandegger
2011-09-18 23:19 ` Calvin Walton
2011-09-16 22:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7AD908.8060101@grandegger.com \
--to=wg@grandegger.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=lambert.willy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.