All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: Chris Ball <cjb@laptop.org>, Will Newton <will.newton@imgtec.com>,
	James Hogan <james.hogan@imgtec.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: [PATCH] mmc: dw_mmc: modified the DMA threshold for SD card
Date: Thu, 22 Sep 2011 19:01:59 +0900	[thread overview]
Message-ID: <4E7B0797.4030605@samsung.com> (raw)

This patch modified the DMA threshold.

I didn't know exactly why need this threshold.
But if this value is 16, we didn't read SCR register for SD card.
Because in mmc_app_send_scr this values are used data.blocks=1 and data.blksz=8.
(data.blocks * data.blksz = 8...so return -EINVAL)

We didn't read the SCR register, then maybe should be set with wrong configuration.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/mmc/host/dw_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 0ed1d28..64e08e2 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -47,7 +47,7 @@
 				 DW_MCI_CMD_ERROR_FLAGS  | SDMMC_INT_HLE)
 #define DW_MCI_SEND_STATUS	1
 #define DW_MCI_RECV_STATUS	2
-#define DW_MCI_DMA_THRESHOLD	16
+#define DW_MCI_DMA_THRESHOLD	8
 
 #ifdef CONFIG_MMC_DW_IDMAC
 struct idmac_desc {

             reply	other threads:[~2011-09-22 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 10:01 Jaehoon Chung [this message]
2011-09-22 10:13 ` [PATCH] mmc: dw_mmc: modified the DMA threshold for SD card James Hogan
2011-09-26  4:24   ` Jaehoon Chung
2011-09-26  8:25     ` James Hogan
2011-09-26  8:34       ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7B0797.4030605@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=cjb@laptop.org \
    --cc=james.hogan@imgtec.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.