All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: ddutile@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qdev: print bus properties too
Date: Fri, 23 Sep 2011 09:44:17 -0500	[thread overview]
Message-ID: <4E7C9B41.2090600@codemonkey.ws> (raw)
In-Reply-To: <1316165105-18315-1-git-send-email-kraxel@redhat.com>

On 09/16/2011 04:25 AM, Gerd Hoffmann wrote:
> Make qdev_device_help print both device and bus properties.
> Helps libvirt to figure whenever bus properties such as
> PCI.multifunction are supported present or not.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/qdev.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index c463c52..a223d41 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -207,6 +207,12 @@ int qdev_device_help(QemuOpts *opts)
>           }
>           error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
>       }
> +    for (prop = info->bus_info->props; prop&&  prop->name; prop++) {
> +        if (!prop->info->parse) {
> +            continue;           /* no way to set it, don't show */
> +        }
> +        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> +    }
>       return 1;
>   }
>

      reply	other threads:[~2011-09-23 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16  9:25 [Qemu-devel] [PATCH] qdev: print bus properties too Gerd Hoffmann
2011-09-23 14:44 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7C9B41.2090600@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.