From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78Go-00031h-76 for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:06:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R78Gn-0003JM-43 for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:06:34 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:36546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78Gn-0003JG-1d for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:06:33 -0400 Received: by yxl11 with SMTP id 11so3540187yxl.4 for ; Fri, 23 Sep 2011 09:06:32 -0700 (PDT) Message-ID: <4E7CAE86.6040103@codemonkey.ws> Date: Fri, 23 Sep 2011 11:06:30 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1316635586-4586-1-git-send-email-dann.frazier@canonical.com> In-Reply-To: <1316635586-4586-1-git-send-email-dann.frazier@canonical.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dann frazier Cc: qemu-devel@nongnu.org On 09/21/2011 03:06 PM, dann frazier wrote: > [Originally sent to qemu-kvm list, but I was redirected here] > > The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of > this bit doesn't appear to change any behavior on Linux/Windows versions we've > tested, but it does cause Windows' PCI/PCI Express Compliance Test to balk. > > I happen to have a physical 82540EM controller, and it also sets the > Capabilities Bit, but it actually has items on the capabilities list to go > with it :) > > Signed-off-by: dann frazier Applied. Thanks. Regards, Anthony Liguori > --- > hw/e1000.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/hw/e1000.c b/hw/e1000.c > index 6a3a941..ce8fc8b 100644 > --- a/hw/e1000.c > +++ b/hw/e1000.c > @@ -1151,8 +1151,6 @@ static int pci_e1000_init(PCIDevice *pci_dev) > > pci_conf = d->dev.config; > > - /* TODO: we have no capabilities, so why is this bit set? */ > - pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST); > /* TODO: RST# value should be 0, PCI spec 6.2.4 */ > pci_conf[PCI_CACHE_LINE_SIZE] = 0x10; >