Re: [KVM-autotest][PATCH] cgroup test with KVM guest +first subtests

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On Fri 23 Sep 2011 12:02:12 PM BRT, Lukáš Doktor wrote:
> Dne 23.9.2011 15:36, Lucas Meneghel Rodrigues napsal(a):
>> On 09/22/2011 01:29 PM, Lukas Doktor wrote:
>>> Hi guys,
>>>
>>> Do you remember the discussion about cgroup testing in autotest vs. 
>>> LTP? I hope there won't be any doubts about this one as ground_test 
>>> (+ first 2 subtests) are strictly focused on cgroups features 
>>> enforced on KVM guest systems. Also more subtests will follow if you 
>>> approve the test structure (blkio_throttle, memory, cpus...).
>>
>> Yes, absolutely.
>>
>>>
>>> No matter whether we drop or keep the general 'cgroup' test. The 
>>> 'cgroup_common.py' library can be imported either from 
>>> 'client/tests/cgroup/' directory or directly from 
>>> 'client/tests/kvm/tests/' directory.
>>
>> I don't think we really need to drop the test. It's useful anyway, 
>> even though there are LTP tests that sort of cover ir.
> Well I have some other ones in a queue. My focus is now on the KVM 
> specific tests, but I might send couple more general cgroup tests 
> later...
>
>>
>>>
>>> The modifications of 'cgroup_common.py' library is backward 
>>> compatible with general cgroup test.
>>>
>>> See the commits for details.
>>
>> Now that we moved to github, I'd like to go with the following model 
>> of contribution:
>>
>> 1) You create a user on github if you don't have one
>> 2) Create a public autotest fork
>> 3) Commit the changes to a topic branch appropriately named
>> 4) Make a pull request to autotest:master
>> 5) You still send the patches to the mailing list normally, but 
>> mention the pull request URL on the message.
>>
>> That's it, we are still trying out things, so if this doesn't work 
>> out, we'll update the process. Is it possible that you do that and 
>> rebase your patches?
>>
>> Oh, and since patchwork is still out due to DNS outage, could you 
>> guys re-spin your client-server patches using the same process I 
>> mentioned? Thank you!
>>
>> Lucas
>
> Hi Lucas,
>
> pull request sent:
> https://github.com/autotest/autotest/pull/6
>
> I'll remind Jiří to do the same with the client-server patches...
>
> Cheers,
> Lukáš

Hi Lukas,

I've made comments on your pull request and I'm waiting on your 
changes. Now, I need to figure out if there's a way to cc a mailing 
list on pull requests...

Still figuring out how the workflow will look like from now on, let's 
see how it goes.