From: Luke Diamand <luke@diamand.org>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org, Vitor Antunes <vitor.hda@gmail.com>,
Chris Li <git@chrisli.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/5] git-p4 filetype handling
Date: Fri, 23 Sep 2011 18:56:19 +0100 [thread overview]
Message-ID: <4E7CC843.8080707@diamand.org> (raw)
In-Reply-To: <20110918012634.GA4578@arf.padd.com>
On 18/09/11 02:26, Pete Wyckoff wrote:
> Here's a series that includes some changes to make
> git-p4 handle p4 filetypes better. This work was
> inspired by Chris Li, and includes some refactoring
> of the git-p4 tests that grew out of looking at
> Vitor's branch changes.
>
> It could use review for generic test beauty, as well
> as for the git-p4 filetype specifics in the code.
Modulo Junio's other comments, this looks sensible to me. I tried it on
a sizeable tree and it didn't scramble anything (but that will only have
tested the 'normal' filetypes).
Do we use $(some_command) rather than `some_command` now?
A few other small comments to follow.
Regards!
Luke
>
> contrib/fast-import/git-p4 | 91 +++++++++++++-----
> t/lib-git-p4.sh | 55 +++++++++++
> t/t9800-git-p4.sh | 108 ++--------------------
> t/t9801-git-p4-branch.sh | 221 ++++++++++++++++++++++++++++++++++++++++++++
> t/t9802-git-p4-filetype.sh | 107 +++++++++++++++++++++
> 5 files changed, 457 insertions(+), 125 deletions(-)
>
> Thanks,
>
> -- Pete
>
prev parent reply other threads:[~2011-09-23 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 1:26 [PATCH 0/5] git-p4 filetype handling Pete Wyckoff
2011-09-18 1:27 ` [PATCH 1/5] git-p4 tests: refactor, split out common functions Pete Wyckoff
2011-09-18 21:48 ` Junio C Hamano
2011-09-21 1:29 ` Pete Wyckoff
2011-09-21 2:34 ` Junio C Hamano
2011-09-21 2:35 ` Junio C Hamano
2011-09-18 1:28 ` [PATCH 2/5] git-p4: handle utf16 filetype properly Pete Wyckoff
2011-09-23 18:01 ` Luke Diamand
2011-09-18 1:29 ` Pete Wyckoff
2011-09-18 1:31 ` [PATCH 3/5] git-p4: recognize all p4 filetypes Pete Wyckoff
2011-09-18 1:32 ` [PATCH 4/5] git-p4: stop ignoring apple filetype Pete Wyckoff
2011-09-18 1:33 ` [PATCH 5/5] git-p4: keyword flattening fixes Pete Wyckoff
2011-09-23 17:56 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7CC843.8080707@diamand.org \
--to=luke@diamand.org \
--cc=git@chrisli.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pw@padd.com \
--cc=vitor.hda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.