From: Frank Rowand <frank.rowand@am.sony.com>
To: "Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL
Date: Fri, 23 Sep 2011 13:15:28 -0700 [thread overview]
Message-ID: <4E7CE8E0.5070604@am.sony.com> (raw)
In-Reply-To: <7186.1316799377@turing-police.cc.vt.edu>
On 09/23/11 10:36, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 22 Sep 2011 14:05:56 PDT, Frank Rowand said:
>> Change from V1 to V2: add drivers/tty/serial/8250.c
>
>> drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/mfd.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/nwpserial.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/omap-serial.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/sunhv.c | 4 2 + 2 - 0 !
>> drivers/tty/serial/sunsab.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/sunsu.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/sunzilog.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/uartlite.c | 2 1 + 1 - 0 !
>> drivers/tty/serial/xilinx_uartps.c | 2 1 + 1 - 0 !
>
>> if (up->port.sysrq)
>> locked = 0;
>> - else if (oops_in_progress) {
>> + else if (oops_in_progress || sysrq_in_progress) {
>> locked = spin_trylock(&up->port.lock);
>> } else
>> spin_lock(&up->port.lock);
>
> Is it time to create a helper function for this chunk of code that appears
> in almost identical form in a dozen drivers?
Thanks for pointing that out. The "if (up->port.sysrq)" in this pattern
already handles the case that I was trying to deal with in all of those
drivers, except cpm_uart_core.c, so I was able to remove all the other
drivers from V3 of the patch.
-Frank
prev parent reply other threads:[~2011-09-23 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 21:05 [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL Frank Rowand
2011-09-23 17:36 ` Valdis.Kletnieks
2011-09-23 20:15 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7CE8E0.5070604@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=Frank_Rowand@sonyusa.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.