From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Kinzler Subject: Re: RE: Stability report GPLPV 0.11.0.308 Date: Fri, 23 Sep 2011 22:57:12 +0200 Message-ID: <4E7CF2A8.5040405@hfp.de> References: <4E64A0DF.2070007@hfp.de> <4E64D569.5030607@hfp.de> <4E7728F9.9020208@hfp.de> <4E7B04A4.9070601@hfp.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080705080205020601040607" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: James Harper Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------080705080205020601040607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hello James, I did take a look at your commit 950 and I think there are 3 typos (see my patch). Anyway, I don't think that memory problems are causing the stability issues and (as some kind of "proof") I did not notice any increase in kernel memory usage during uptime of the VMs. Actually I am not really sure if xennet is even the problem since in none of the crash scenarios there was something in the Windows event log. In my last test I was able to enter my password via VNC (it did not login though) - this should have written some entries to the security log which it did not. So I assume that xenvbd was dead too (killed by xennet) or is actually the real reason for the stability problems. Regards Andreas --------------080705080205020601040607 Content-Type: text/plain; name="diff.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="diff.patch" --- x\xennet6_rx.c 2011-09-22 13:47:46.000000000 +0200 +++ xennet6_rx.c 2011-09-23 22:39:47.892796400 +0200 @@ -50,8 +50,8 @@ pb->mdl = IoAllocateMdl(pb->virtual, PAGE_SIZE, FALSE, FALSE, NULL); if (!pb->mdl) { - NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0); - NdisFreeMemory(pb, PAGE_SIZE, 0); + NdisFreeMemory(pb->virtual, PAGE_SIZE, 0); + NdisFreeMemory(pb, sizeof(shared_buffer_t), 0); return NULL; } pb->gref = (grant_ref_t)xi->vectors.GntTbl_GrantAccess(xi->vectors.context, 0, @@ -59,8 +59,8 @@ if (pb->gref == INVALID_GRANT_REF) { IoFreeMdl(pb->mdl); - NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0); - NdisFreeMemory(pb, PAGE_SIZE, 0); + NdisFreeMemory(pb->virtual, PAGE_SIZE, 0); + NdisFreeMemory(pb, sizeof(shared_buffer_t), 0); return NULL; } MmBuildMdlForNonPagedPool(pb->mdl); @@ -85,8 +85,8 @@ if (xi->rx_pb_free > RX_MAX_PB_FREELIST) { IoFreeMdl(pb->mdl); - NdisFreeMemory(pb->virtual, sizeof(shared_buffer_t), 0); - NdisFreeMemory(pb, PAGE_SIZE, 0); + NdisFreeMemory(pb->virtual, PAGE_SIZE, 0); + NdisFreeMemory(pb, sizeof(shared_buffer_t), 0); return; } pb->mdl->ByteCount = PAGE_SIZE; --------------080705080205020601040607 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------080705080205020601040607--