Re: [PATCH 1/17]DVB:Siano drivers - Adding LKM for handling SPI connected devices.

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 25-09-2011 07:25, Doron Cohen escreveu:
> On Fri, 2011-09-23 at 17:20 -0300, Mauro Carvalho Chehab wrote:
>> Em 20-09-2011 07:30, Doron Cohen escreveu:
>>> Hi,
>>> It took a long time to merge all the changes in kernel.org with Siano
>>> sources which were updated in a different repository for the last couple
>>> of years.
>>> I have made all the changes in small steps seperated to functional
>>> reasons.
>>> First patch is actually adding new kernel object which handles SPI
>>> connection and used the spidrv of the kernel.
>>> module is used mainly in android platforms but is a pure LKM works with
>>> siano modules stack.
>>>
>>> Thanks,
>>> Doron Cohen

> Hi Mauro,
> Thanks for your response.
> I am going over your comments and changing my patches according to your
> comments. Also running the checkpatch script and remove all errors and
> warnings.

Thanks!
> 
> Please advice what would be the right way to continue:
> 1. Reply each patch and put the new corrected patch below the old
> commented patch.
> or
> 2. Open a new thread with the corrected patch.

What most developers do is to argument against my review when needed, 
using the existing thread. Then, they open a [PATCH v2] thread with
the new patchset.

Regards,
Mauro