From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Chris Rankin <rankincj@yahoo.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v3] EM28xx - fix deadlock when unplugging and replugging a DVB adapter
Date: Sun, 25 Sep 2011 09:49:28 -0300 [thread overview]
Message-ID: <4E7F2358.7090906@redhat.com> (raw)
In-Reply-To: <4E7E43A2.3020905@yahoo.com>
Em 24-09-2011 17:54, Chris Rankin escreveu:
> This fixes the deadlock that occurs with either multiple PCTV 290e adapters or when a single PCTV 290e adapter is replugged.
>
> For DVB devices, the device lock must now *not* be held when adding/removing either a device or an extension to the respective lists. (Because em28xx_init_dvb() will want to take the lock instead).
>
> Conversely, for Audio-Only devices, the device lock *must* be held when adding/removing either a device or an extension to the respective lists.
>
> Signed-off-by: Chris Rankin <ranki...@yahoo.com>
Ok, I've applied it, but it doesn't sound a good idea to me to do:
+ mutex_unlock(&dev->lock);
em28xx_init_extension(dev);
+ mutex_lock(&dev->lock);
I'll later test it with some hardware and see how well this behaves
in practice.
Thanks,
Mauro
next prev parent reply other threads:[~2011-09-25 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 20:54 [PATCH v3] EM28xx - fix deadlock when unplugging and replugging a DVB adapter Chris Rankin
2011-09-25 12:49 ` Mauro Carvalho Chehab [this message]
2011-09-25 13:20 ` Chris Rankin
2011-09-25 19:28 ` Chris Rankin
2011-09-25 19:45 ` Mauro Carvalho Chehab
2011-09-25 21:36 ` Chris Rankin
2011-09-25 13:00 ` Mauro Carvalho Chehab
2011-09-25 13:32 ` Chris Rankin
2011-09-25 19:43 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7F2358.7090906@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.