From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] qemu: Fix inject-nmi Date: Sun, 25 Sep 2011 19:22:38 +0200 Message-ID: <4E7F635E.6080009@web.de> References: <20110913093835.GB4265@localhost.localdomain> <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com> <4E705BC3.5000508@cn.fujitsu.com> <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com> <4E71B28F.7030201@cn.fujitsu.com> <4E72F3BA.2000603@jp.fujitsu.com> <4E73200A.7040908@jp.fujitsu.com> <4E76C6AA.9080403@cn.fujitsu.com> <4E7B04DC.1030407@cn.fujitsu.com> <4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com> <4E7F3585.40108@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB2DB9D06661C750C64CA937D" Cc: Kenji Kaneshige , KAMEZAWA Hiroyuki , Lai Jiangshan , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Avi Kivity Return-path: In-Reply-To: <4E7F3585.40108@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB2DB9D06661C750C64CA937D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? = You >> > may want to provide a patch for that tree, emulating the unavailabl= e >> > LINT1 injection via testing the APIC configration and then raising = an >> > NMI as before if it is accepted. >> > >> >> It works in my box but the NMI is not injected through the in-kernel >> irqchip, >> I will implement it as you suggested. >=20 > Somewhat hacky; isn't it better to test LINT1 in the kernel (and > redefine the KVM_NMI ioctl as "toggle LINT1")? KVM_NMI is required for user space IRQ chip as well. Introducing some KVM_SET_LINT1 is an option though. But emulating it for the NMI button on older kernels sounds worthwhile nevertheless. Jan --------------enigB2DB9D06661C750C64CA937D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5/Y14ACgkQitSsb3rl5xS/+wCfclc6kV4aYnY90igzaNGer85i qrgAoMoXyD/UjHoPcLuIAtFFzdjsEyYj =GVTZ -----END PGP SIGNATURE----- --------------enigB2DB9D06661C750C64CA937D-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7sPa-0004vX-G7 for qemu-devel@nongnu.org; Sun, 25 Sep 2011 13:22:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7sPZ-0006EB-CG for qemu-devel@nongnu.org; Sun, 25 Sep 2011 13:22:42 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:50610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7sPY-0006Ds-Rr for qemu-devel@nongnu.org; Sun, 25 Sep 2011 13:22:41 -0400 Message-ID: <4E7F635E.6080009@web.de> Date: Sun, 25 Sep 2011 19:22:38 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110913093835.GB4265@localhost.localdomain> <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com> <4E705BC3.5000508@cn.fujitsu.com> <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com> <4E71B28F.7030201@cn.fujitsu.com> <4E72F3BA.2000603@jp.fujitsu.com> <4E73200A.7040908@jp.fujitsu.com> <4E76C6AA.9080403@cn.fujitsu.com> <4E7B04DC.1030407@cn.fujitsu.com> <4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com> <4E7F3585.40108@redhat.com> In-Reply-To: <4E7F3585.40108@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB2DB9D06661C750C64CA937D" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kenji Kaneshige , KAMEZAWA Hiroyuki , Lai Jiangshan , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB2DB9D06661C750C64CA937D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? = You >> > may want to provide a patch for that tree, emulating the unavailabl= e >> > LINT1 injection via testing the APIC configration and then raising = an >> > NMI as before if it is accepted. >> > >> >> It works in my box but the NMI is not injected through the in-kernel >> irqchip, >> I will implement it as you suggested. >=20 > Somewhat hacky; isn't it better to test LINT1 in the kernel (and > redefine the KVM_NMI ioctl as "toggle LINT1")? KVM_NMI is required for user space IRQ chip as well. Introducing some KVM_SET_LINT1 is an option though. But emulating it for the NMI button on older kernels sounds worthwhile nevertheless. Jan --------------enigB2DB9D06661C750C64CA937D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5/Y14ACgkQitSsb3rl5xS/+wCfclc6kV4aYnY90igzaNGer85i qrgAoMoXyD/UjHoPcLuIAtFFzdjsEyYj =GVTZ -----END PGP SIGNATURE----- --------------enigB2DB9D06661C750C64CA937D--