From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R86Ct-00015k-HU for qemu-devel@nongnu.org; Mon, 26 Sep 2011 04:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R86Cs-0005Sp-HK for qemu-devel@nongnu.org; Mon, 26 Sep 2011 04:06:31 -0400 Received: from goliath.siemens.de ([192.35.17.28]:29883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R86Cs-0005Sa-5I for qemu-devel@nongnu.org; Mon, 26 Sep 2011 04:06:30 -0400 Message-ID: <4E80327E.1090006@siemens.com> Date: Mon, 26 Sep 2011 10:06:22 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <55cdae9265253263fb7dbc883d3297e52b13763f.1316537591.git.jan.kiszka@siemens.com> <12AA37D0-AEAC-4128-AEBF-A1A18B6F934A@web.de> In-Reply-To: <12AA37D0-AEAC-4128-AEBF-A1A18B6F934A@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] audio: Switch coreaudio to QemuMutex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , Anthony Liguori , "qemu-devel@nongnu.org" On 2011-09-26 09:58, Andreas F=E4rber wrote: > Hello Jan, >=20 > Am 20.09.2011 um 18:53 schrieb Jan Kiszka: >=20 >> Using the error management of QemuMutex allows to simplify the code. >> >> CC: malc >> CC: Andreas F=E4rber >> Signed-off-by: Jan Kiszka >> --- >> audio/coreaudio.c | 56 +++++++--------------------------------------= ------- >> 1 files changed, 8 insertions(+), 48 deletions(-) >=20 > You missed one coreaudio_unlock() occurrence in line 187. Other than th= at looks okay, with some more softfloat workarounds it compiles and doesn= 't noticeably regress on Darwin/i386 v10.6.8. >=20 > diff --git a/audio/coreaudio.c b/audio/coreaudio.c > index c34a593..1cb3fce 100644 > --- a/audio/coreaudio.c > +++ b/audio/coreaudio.c > @@ -184,7 +184,7 @@ static int coreaudio_run_out (HWVoiceOut *hw, int l= ive) > core->live =3D live - decr; > hw->rpos =3D core->rpos; >=20 > - coreaudio_unlock (core, "coreaudio_run_out"); > + qemu_mutex_unlock(&core->mutex); > return decr; > } >=20 >=20 > Do you have a particular test case? Any parameters needed? I've never u= sed audio in my guests. ;) Nope, I hoped you had. :) But I received indications that the implicit logging removal is not welcome. So I will likely refrain from touching the audio subsystem in the first step. Thanks, Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux