All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Balister <philip@balister.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/eth: add newline to "failed MAC address" warning
Date: Mon, 26 Sep 2011 10:24:54 -0400	[thread overview]
Message-ID: <4E808B36.6020404@balister.org> (raw)
In-Reply-To: <1316782071-8988-1-git-send-email-holger.brunck@keymile.com>

On 09/23/2011 08:47 AM, Holger Brunck wrote:
> This prevents u-boot to display during bootime:
> Out:   serial
> Err:   serial
> Net:   UEC3Warning: failed to set MAC address
>
> Now corrected and it will display:
> Out:   serial
> Err:   serial
> Net:   UEC3
> Warning: failed to set MAC address
>
> Signed-off-by: Holger Brunck<holger.brunck@keymile.com>

Acked-by: Philip Balister <philip@opensdr.com>

But, when i submitted the same patch, I was told this is not the right 
way to solve the problem. I would still like to see this patch go in 
until someone has time to rewrite the problem section of code.

Philip

> ---
>   net/eth.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 02baa37..1c0c780 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis)
>   				puts("\nWarning: eth device name has a space!\n");
>
>   			if (eth_write_hwaddr(dev, "eth", eth_number))
> -				puts("Warning: failed to set MAC address\n");
> +				puts("\nWarning: failed to set MAC address\n");
>
>   			eth_number++;
>   			dev = dev->next;

  reply	other threads:[~2011-09-26 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 12:47 [U-Boot] [PATCH] net/eth: add newline to "failed MAC address" warning Holger Brunck
2011-09-26 14:24 ` Philip Balister [this message]
2011-09-26 16:07   ` Mike Frysinger
2011-09-26 16:40     ` Holger Brunck
2011-10-01 19:55 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E808B36.6020404@balister.org \
    --to=philip@balister.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.