From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream Date: Mon, 26 Sep 2011 19:23:23 +0200 Message-ID: <4E80B50B.9000301@siemens.com> References: <4E78C42D.5030207@siemens.com> <20110921080600.GA9847@stefanha-thinkpad.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm , Anthony Liguori , Kevin Wolf To: Stefan Hajnoczi Return-path: Received: from goliath.siemens.de ([192.35.17.28]:17791 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474Ab1IZRXf (ORCPT ); Mon, 26 Sep 2011 13:23:35 -0400 In-Reply-To: <20110921080600.GA9847@stefanha-thinkpad.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-09-21 10:06, Stefan Hajnoczi wrote: > On Tue, Sep 20, 2011 at 06:49:49PM +0200, Jan Kiszka wrote: >> Upstream's version is about to be signal-free and will stop handling >> SIGUSR2 specially. So it's time to adopt its implementation, ie. switch >> from signalfd to a pipe. >> >> Signed-off-by: Jan Kiszka >> --- >> >> This should help pulling upstream into qemu-kvm when "block: avoid >> SIGUSR2" is merged. And will help merging further cleanups of this code >> I'm working on. >> >> posix-aio-compat.c | 73 ++++++++++++++++++++++----------------------------- >> 1 files changed, 32 insertions(+), 41 deletions(-) > > Reviewed-by: Stefan Hajnoczi > > Perhaps qemu_eventfd() can be used in the future instead of an explicit > pipe. Then Linux will do eventfd while other OSes will fall back to > pipes. Basically simpler code, or does this also have runtime benefits? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux