From: Vladimir Zapolskiy <vz@mleia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines
Date: Mon, 26 Sep 2011 22:24:27 +0300 [thread overview]
Message-ID: <4E80D16B.8060107@mleia.com> (raw)
In-Reply-To: <20110923060634.50D2F140797A@gemini.denx.de>
Hello Wolfgang,
On 23.09.2011 09:06, Wolfgang Denk wrote:
> Dear Andy Fleming,
>
> In message<CAKWjMd5HGT9df76vPFs8B5sFQYWoAN1bGmt2vRihN0cTa1boug@mail.gmail.com> you wrote:
>>
>> Shoot, I just saw this patch in my tree. It's incorrect.
>
> Argh...
>
>> The lines weren't redundant. The logic is (and probably should be
>> better commented):
>>
>> Find the intersection of the advertised capabilities of both sides of
>> the link (lpa)
>> From that intersection, find the highest capability we can run at
>> (that will be the negotiated link)
>>
>> Now imagine that the intersection (lpa) is (LPA_100HALF | LPA_10FULL).
>>
>> The code will now set phydev->speed to 100, and phydev->duplex to 1,
>> but this link does not support 100FULL.
>
> Do we agree that I should revert this commit?
>
due to Andy's explanation I agree that this change is fishy and it
should be reverted.
As a U-Boot user I'd greatly appreciate, if you add the above note to
the commit message.
Sorry for inconvenience.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2011-09-26 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 17:24 [U-Boot] [PATCH 0/2] phylib: a couple of minor fixes in generic phy library Vladimir Zapolskiy
2011-09-05 17:24 ` [U-Boot] [PATCH 1/2] phylib: reset mii bus only if reset handler is registered Vladimir Zapolskiy
2011-09-09 13:27 ` Detlev Zundel
2011-09-09 22:08 ` Wolfgang Denk
2011-09-22 21:44 ` Andy Fleming
2011-09-22 22:13 ` Mike Frysinger
2011-09-22 22:19 ` Andy Fleming
2011-09-05 17:24 ` [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines Vladimir Zapolskiy
2011-09-09 12:18 ` Detlev Zundel
2011-09-09 22:08 ` Wolfgang Denk
2011-09-22 21:25 ` Andy Fleming
2011-09-23 6:06 ` Wolfgang Denk
2011-09-26 19:24 ` Vladimir Zapolskiy [this message]
2011-09-28 19:05 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80D16B.8060107@mleia.com \
--to=vz@mleia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.