From: Timur Tabi <timur@freescale.com>
To: linux-fbdev@vger.kernel.org
Subject: Question on struct fb_videomode.name
Date: Mon, 26 Sep 2011 20:55:45 +0000 [thread overview]
Message-ID: <4E80E6D1.3010907@freescale.com> (raw)
In my fb driver, I have an array of fb_videomode structs, like this:
static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
{
.name = "1024x768-60",
.refresh = 60,
.xres = 1024,
.yres = 768,
.pixclock = 15385,
.left_margin = 160,
.right_margin = 24,
.upper_margin = 29,
.lower_margin = 3,
.hsync_len = 136,
.vsync_len = 6,
.sync = FB_SYNC_COMP_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
.vmode = FB_VMODE_NONINTERLACED
},
...
Is there any value in specifying the .name field as "<xres>x<yres>-<ref>"? I
know the .name field is optional, but what happens if I don't specify it? It
just seems redundant to generate the name based on other data in the same structure.
--
Timur Tabi
Linux kernel developer at Freescale
next reply other threads:[~2011-09-26 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 20:55 Timur Tabi [this message]
2011-09-27 12:22 ` Question on struct fb_videomode.name Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E80E6D1.3010907@freescale.com \
--to=timur@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.