From: Archit Taneja <archit@ti.com>
To: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>
Cc: "Hiremath, Vaibhav" <hvaibhav@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Semwal, Sumit" <sumit.semwal@ti.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe
Date: Tue, 27 Sep 2011 12:32:39 +0530 [thread overview]
Message-ID: <4E81750F.7060200@ti.com> (raw)
In-Reply-To: <1317103833.1991.6.camel@deskari>
On Tuesday 27 September 2011 11:40 AM, Valkeinen, Tomi wrote:
> On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote:
>> Remove the code in omap_vout_probe() which calls display->driver->update() for
>> all the displays. This isn't correct because:
>>
>> - An update in probe doesn't make sense, because we don't have any valid content
>> to show at this time.
>> - Calling update for a panel which isn't enabled is not supported by DSS2. This
>> leads to a crash at probe.
>
> Calling update() on a disabled panel should not crash... Where is the
> crash coming from?
you are right, the crash isn't coming from the updates. I see the crash
when we have 4 dss devices in our board file. The last display pointer
is corrupted in that case. I'm trying to figure out why.
Archit
>
> Tomi
>
>
next prev parent reply other threads:[~2011-09-27 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 11:59 [PATCH v3 0/4] OMAP_VOUT: Misc fixes and cleanup patches for 3.2 Archit Taneja
2011-09-26 11:59 ` Archit Taneja
2011-09-26 11:59 ` [PATCH v3 1/4] OMAP_VOUT: Fix check in reqbuf for buf_size allocation Archit Taneja
2011-09-26 11:59 ` Archit Taneja
2011-09-27 7:19 ` Hiremath, Vaibhav
2011-09-27 7:23 ` Archit Taneja
2011-09-26 11:59 ` [PATCH v3 2/4] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr Archit Taneja
2011-09-26 11:59 ` Archit Taneja
2011-09-26 11:59 ` [PATCH v3 3/4] OMAP_VOUT: Add support for DSI panels Archit Taneja
2011-09-26 11:59 ` Archit Taneja
2011-09-26 11:59 ` [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe Archit Taneja
2011-09-26 11:59 ` Archit Taneja
2011-09-27 6:10 ` Tomi Valkeinen
2011-09-27 7:02 ` Archit Taneja [this message]
2011-09-27 7:07 ` Tomi Valkeinen
2011-09-27 7:15 ` Archit Taneja
2011-09-27 6:26 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81750F.7060200@ti.com \
--to=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sumit.semwal@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.