From: "Roland Vossen" <rvossen@broadcom.com>
To: jak@jak-linux.org
Cc: "Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"gregkh@suse.de" <gregkh@suse.de>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Fwd: [PATCH 16/20] staging: brcm80211: declared global vars in softmac phy as const
Date: Tue, 27 Sep 2011 09:52:16 +0200 [thread overview]
Message-ID: <4E8180B0.2060202@broadcom.com> (raw)
In-Reply-To: <4E80B37C.4060106@broadcom.com>
Hello Julian,
>> diff --git a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c
>> index 15c5ffc..1b11b2f 100644
>> --- a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c
>> +++ b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c
>> @@ -1611,7 +1611,7 @@ const u32 dot11lcnphytbl_rx_gain_info_sz_rev0 =
>> sizeof(dot11lcnphytbl_rx_gain_info_rev0) /
>> sizeof(dot11lcnphytbl_rx_gain_info_rev0[0]);
>>
>> -static const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 =
>> +const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 =
>> sizeof(dot11lcnphytbl_rx_gain_info_rev1) /
>> sizeof(dot11lcnphytbl_rx_gain_info_rev1[0]);
>
> That seems like an anomaly. In a commit that is supposed
> to declare variables as const, the linkage of a variable
> changed.
The name of this commit could have been better. It should have been
'fixed sparse warnings on variable usage in softmac phy'. For what it is
worth: this variable is deleted in a later commit.
> Likewise, the removal of extern global variable
> declarations in phy_int.h also does not seem to belong
> here.
Agree.
The whole patch series will be resent anyway, let me split this commit
up in two to address your feedback.
Thanks, Roland.
next prev parent reply other threads:[~2011-09-27 7:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 2:08 [PATCH 00/20] staging: brcm80211: 8th reaction for mainline patch #2 Franky Lin
2011-09-24 2:08 ` [PATCH 01/20] staging: brcm80211: remove uncoditional code blocks from brcmsmac Franky Lin
2011-09-24 2:08 ` [PATCH 02/20] staging: brcm80211: removed unused argument from softmac functions Franky Lin
2011-09-24 2:08 ` [PATCH 03/20] staging: brcm80211: deleted unused array of bss configurations in softmac Franky Lin
2011-09-24 2:08 ` [PATCH 04/20] staging: brcm80211: removed redundant wlc->cfg struct member Franky Lin
2011-09-24 2:08 ` [PATCH 05/20] staging: brcm80211: removed global var from aiutils.c Franky Lin
2011-09-24 2:08 ` [PATCH 06/20] staging: brcm80211: removed global vars in softmac ucode handling Franky Lin
2011-09-24 2:08 ` [PATCH 07/20] staging: brcm80211: removed unused softmac workaround Franky Lin
2011-09-24 2:08 ` [PATCH 08/20] staging: brcm80211: cleanup structure fields used for scanning Franky Lin
2011-09-26 19:07 ` Franky Lin
2011-09-24 2:08 ` [PATCH 09/20] staging: brcm80211: use endian annotated structures in brcmsmac Franky Lin
2011-09-24 10:38 ` Johannes Berg
2011-09-24 12:34 ` Arend van Spriel
2011-09-26 9:37 ` Johannes Berg
2011-09-26 18:26 ` Arend van Spriel
2011-09-26 19:17 ` Franky Lin
2011-09-26 23:50 ` Greg KH
2011-09-27 0:08 ` Franky Lin
2011-09-26 21:06 ` Rafał Miłecki
2011-09-27 9:54 ` Arend van Spriel
2011-09-24 2:08 ` [PATCH 10/20] staging: brcm80211: remove ht_cap field from brcms_c_info structure Franky Lin
2011-09-24 2:08 ` [PATCH 11/20] staging: brcm80211: use fragment number provided in transmit frame Franky Lin
2011-09-24 2:09 ` [PATCH 12/20] staging: brcm80211: remove unused function si_pmu_ilp_clock() Franky Lin
2011-09-24 2:09 ` [PATCH 13/20] staging: brcm80211: make device initializer table for wme constant Franky Lin
2011-09-24 2:09 ` [PATCH 14/20] staging: brcm80211: remove dongle firmware related debug code Franky Lin
2011-09-24 10:39 ` Johannes Berg
2011-09-24 14:49 ` Arend van Spriel
2011-09-24 2:09 ` [PATCH 15/20] staging: brcm80211: remove unnecessary mac80211 callbacks Franky Lin
2011-09-24 2:09 ` [PATCH 16/20] staging: brcm80211: declared global vars in softmac phy as const Franky Lin
2011-09-24 9:52 ` Julian Andres Klode
[not found] ` <4E80B37C.4060106@broadcom.com>
2011-09-27 7:52 ` Roland Vossen [this message]
2011-09-24 2:09 ` [PATCH 17/20] staging: brcm80211: removed band related global vars from softmac Franky Lin
2011-09-24 2:09 ` [PATCH 18/20] staging: brcm80211: removed global var global_scb " Franky Lin
2011-09-24 2:09 ` [PATCH 19/20] staging: brcm80211: various global var related changes in softmac Franky Lin
2011-09-24 2:09 ` [PATCH 20/20] staging: brcm80211: removed global variable in softmac otp Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8180B0.2060202@broadcom.com \
--to=rvossen@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=jak@jak-linux.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.