All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away)
Date: Tue, 27 Sep 2011 11:57:54 +0300	[thread overview]
Message-ID: <4E819012.6090100@redhat.com> (raw)
In-Reply-To: <4E818A5A.6000605@redhat.com>

On 09/27/2011 11:33 AM, Avi Kivity wrote:
> On 09/26/2011 09:07 PM, Blue Swirl wrote:
>> >>  The default address is used for early serial printk in OpenBIOS, 
>> so it
>> >>  should still work.
>> >
>> >  Ok, so drop the extra mapping, but init the dynamic mapping to 
>> 0x80013000.
>>
>> That should work.
>
> It's already there (macio.c):
>
>     if (macio_state->escc_mem) {
>         memory_region_add_subregion(bar, 0x13000, macio_state->escc_mem);
>     }
>
> I'll drop the extra mapping.
>

Well, it's not that easy.  As the other mapping is part of an ordinary 
BAR, you need to setup the device (at least PCI_COMMAND and 
PCI_BASE_ADDRESS_0) so it responds to memory requests, and also enable 
the bridge.

We could hack it by having a low-priority mapping at 0x80013000, but it 
seems wrong.  Maybe the firmware should configure that BAR first?  What 
happens on real hardware?

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-09-27  8:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22  0:34 [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three weeks away) Anthony Liguori
2011-09-24  8:05 ` Blue Swirl
2011-09-25 14:10   ` Avi Kivity
2011-09-25 16:36     ` Blue Swirl
2011-09-25 16:48       ` Avi Kivity
2011-09-25 17:31         ` Blue Swirl
2011-09-26 10:08           ` Avi Kivity
2011-09-26 10:10             ` Avi Kivity
2011-09-26 17:15             ` Blue Swirl
2011-09-26 17:18               ` Avi Kivity
2011-09-26 17:20                 ` Blue Swirl
2011-09-26 17:24                   ` Avi Kivity
2011-09-26 18:07                     ` Blue Swirl
2011-09-27  8:33                       ` Avi Kivity
2011-09-27  8:57                         ` Avi Kivity [this message]
2011-09-27 16:39                           ` Blue Swirl
2011-09-27 16:44                             ` Avi Kivity
2011-09-27 19:19                               ` Blue Swirl
2011-09-28 21:21                                 ` Alexander Graf
2011-09-29 19:28                                   ` Blue Swirl
2011-09-29 21:19                                     ` Alexander Graf
2011-09-25 19:50     ` Anthony Liguori
2011-09-30  3:21 ` Stefan Berger
2011-09-30 12:59   ` Anthony Liguori
2011-09-30 14:05     ` Stefan Berger
2011-10-10 12:14 ` Max Filippov
  -- strict thread matches above, loose matches on Subject: below --
2011-09-24 21:56 Anthony Liguori
2011-09-25 16:28 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E819012.6090100@redhat.com \
    --to=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.