From: Josef Bacik <josef@redhat.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: break out of orphan cleanup if we can't make progress
Date: Tue, 27 Sep 2011 11:11:08 -0400 [thread overview]
Message-ID: <4E81E78C.80804@redhat.com> (raw)
In-Reply-To: <20110927144413.GE22205@twin.jikos.cz>
On 09/27/2011 10:44 AM, David Sterba wrote:
> On Mon, Sep 26, 2011 at 03:56:29PM -0400, Josef Bacik wrote:
>> I noticed while running xfstests 83 that if we didn't have enough space to
>> delete our inode the orphan cleanup would just loop. This is because it keeps
>> finding the same orphan item and keeps trying to kill it but can't because we
>> don't get an error back from iput for deleting the inode.
>
> It would make more sense to catch this error rather than bailing out.
> One undeletable orphan forbids any following orphans to be deleted until
> next mount(?), dunno.
>
Yeah but since iput doesn't return an error there's only so much I can
do. I suppose I could just bypass all of this and call delete by hand,
but that seems ugly and prone to other failures. Really this shouldn't
happen at all, but at least this will keep the thing from mounting and
then we can debug the issue further without bringing the users box to a
halt. Thanks,
Josef
next prev parent reply other threads:[~2011-09-27 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 19:56 [PATCH] Btrfs: break out of orphan cleanup if we can't make progress Josef Bacik
2011-09-27 14:44 ` David Sterba
2011-09-27 15:11 ` Josef Bacik [this message]
2011-09-30 11:50 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81E78C.80804@redhat.com \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.