From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: remove XEN_PLATFORM_PCI config option Date: Tue, 27 Sep 2011 09:50:51 -0700 Message-ID: <4E81FEEB.7040100@goop.org> References: <1316776753-10168-1-git-send-email-stefano.stabellini@eu.citrix.com> <4E7C9ADD.6010209@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: Ian Campbell , "xen-devel@lists.xensource.com" , "konrad.wilk@oracle.com" List-Id: xen-devel@lists.xenproject.org On 09/27/2011 07:46 AM, Stefano Stabellini wrote: > On Fri, 23 Sep 2011, Jeremy Fitzhardinge wrote: >> On 09/23/2011 04:19 AM, stefano.stabellini@eu.citrix.com wrote: >>> From: Stefano Stabellini >>> >>> Xen PVHVM needs xen-platform-pci, on the other hand xen-platform-pci is >>> useless in any other cases. >>> Therefore remove the XEN_PLATFORM_PCI config option and compile >>> xen-platform-pci built-in if XEN_PVHVM is selected. >> What happens if you disable CONFIG_PCI? >> >> I think XEN_PLATFORM_PCI still needs to exist, but just not user-visible. > What if we add CONFIG_PCI as a dependency of XEN_PVHVM? > > It is not like it is going to be useful to run a PV on HVM guest without > PV drivers. In principle you could have a domain with emulated ISA IDE and net but with PV time, etc. But yeah, not very useful in practice. I think making PVHVM depend on PCI is fine. J