All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Kendall <wkendall@sgi.com>
To: aelder@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: handle dump files with checksum bug
Date: Tue, 27 Sep 2011 14:17:04 -0500	[thread overview]
Message-ID: <4E822130.70004@sgi.com> (raw)
In-Reply-To: <1316791615.2879.50.camel@doink>

On 09/23/2011 10:26 AM, Alex Elder wrote:
> On Fri, 2011-09-23 at 07:45 -0500, Bill Kendall wrote:
>> +				mlog( MLOG_NORMAL | MLOG_WARNING, _(
>> +					"extattr header checksum "
>> +					"could not be verified\n") );
>
> Is there any way to slightly change this message so
> that someone who saw it would feel like "I got this
> warning but it's really OK"?  If I were a user and
> got this message I would be a little afraid that
> it meant something was really wrong with what got
> restored--possibly the whole thing, or just on
> some unnamed file, never to be found.
>
> Maybe "old-style extattr header checksums being
> ignored".  (I'm sure you can come up with better,
> I just like to offer *something* when I suggest
> a change.)

I more or less like what you've suggested. How about this:

    "ignoring old-style extattr header checksums"

Bill

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2011-09-27 19:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 12:45 [PATCH] xfsdump: handle dump files with checksum bug Bill Kendall
2011-09-23 15:26 ` Alex Elder
2011-09-27 19:17   ` Bill Kendall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E822130.70004@sgi.com \
    --to=wkendall@sgi.com \
    --cc=aelder@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.